Giter VIP home page Giter VIP logo

leyou's People

Contributors

dependabot[bot] avatar lyj8330328 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

leyou's Issues

写代码务必注意健壮性,不然连抄都没法让人抄。。。

`package com.leyou.item.service.impl;

import com.leyou.item.service.SpecificationService;
import com.leyou.item.mapper.SpecificationMapper;
import com.leyou.item.pojo.Specification;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service;

/**

  • @author: 98050

  • Time: 2018-08-14 15:26

  • Feature:
    */
    @service
    public class SpecificationServiceImpl implements SpecificationService {

    @Autowired
    private SpecificationMapper specificationMapper;

    @OverRide
    public Specification queryById(Long id) {
    return this.specificationMapper.selectByPrimaryKey(id);
    }

    @OverRide
    public void saveSpecification(Specification specification) {
    this.specificationMapper.insert(specification);
    }

    @OverRide
    public void updateSpecification(Specification specification) {
    this.specificationMapper.updateByPrimaryKeySelective(specification);
    }

    @OverRide
    public void deleteSpecification(Specification specification) {
    this.specificationMapper.deleteByPrimaryKey(specification);
    }
    }`

例如delete这边,明明只需要根据id去删除就ok了。哪有直接传个对象进行删除的???
public void deleteSpecificationByCategoryId(Long id){ if (id == null || this.specificationMapper.selectByPrimaryKey(id) == null){ throw new LyException(ExceptionEnum.ID_DOES_NOT_EXIST); } this.specificationMapper.deleteByPrimaryKey(id); }
顺带你controller里面很多错,尽管编译器不一定会报错。然而。。你这逻辑不对十分尴尬

一点小建议-关于仓库

我见加载工程比较慢,原来是从国外下载jar包,我记得我本地maven配的是阿里的啊,原来pom.xml中有做配置,建议把pom中修改阿里的,或者删掉,用本地的

商品分类查询健壮性的考虑是不是有问题

//如果pid的值为-1那么需要获取数据库中最后一条数据,(并没有发现这样能有什么意义)
if (pid == -1){
List last = this.categoryService.queryLast();
return ResponseEntity.ok(last);
}
查询数据库最后一个记录感觉没必要,问一下作者是怎么考虑的

嘤嘤嘤

大佬,能加个好友么,有些问题想请教你一下

规格参数这个功能是没有做吗?

缺少了两个表 tb_spec_group 和 tb_spec_param
再三检查了项目中给的SQL也没有这两个表
我用的后端页面不是你仓库中的,和这个有关系吗?

程序包com.sun.istack.internal不存在

编译错误:
Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project leyou-common: Compilation failure: Compilation failure:
[ERROR] /C:/home/lakala/ec/src/leyou/leyou-master/leyou-common/src/main/java/com/leyou/utils/JsonUtils.java:[6,31] 程序包com.sun.istack.internal不存在
[ERROR] /C:/home/lakala/ec/src/leyou/leyou-master/leyou-common/src/main/java/com/leyou/utils/JsonUtils.java:[24,6] 找不到符号
[ERROR] 符号: 类 Nullable
[ERROR] 位置: 类 com.leyou.utils.JsonUtils
[ERROR] /C:/home/lakala/ec/src/leyou/leyou-master/leyou-common/src/main/java/com/leyou/utils/JsonUtils.java:[40,6] 找不到符号
[ERROR] 符号: 类 Nullable
[ERROR] 位置: 类 com.leyou.utils.JsonUtils
[ERROR] /C:/home/lakala/ec/src/leyou/leyou-master/leyou-common/src/main/java/com/leyou/utils/JsonUtils.java:[50,6] 找不到符号
[ERROR] 符号: 类 Nullable
[ERROR] 位置: 类 com.leyou.utils.JsonUtils
[ERROR] /C:/home/lakala/ec/src/leyou/leyou-master/leyou-common/src/main/java/com/leyou/utils/JsonUtils.java:[60,6] 找不到符号
[ERROR] 符号: 类 Nullable
[ERROR] 位置: 类 com.leyou.utils.JsonUtils
[ERROR] /C:/home/lakala/ec/src/leyou/leyou-master/leyou-common/src/main/java/com/leyou/utils/JsonUtils.java:[70,6] 找不到符号
[ERROR] 符号: 类 Nullable
[ERROR] 位置: 类 com.leyou.utils.JsonUtils

search模块缺少方法querySpuDetailBySpuId

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'searchController' defined in file [E:\20200218\leyou\leyou-search\target\classes\com\leyou\controller\SearchController.class]: Invocation of init method failed; nested exception is feign.FeignException: status 404 reading GoodsClient#querySpuDetailBySpuId(Long)

关于乐优商城的代码问题

黑马的乐优商城代码更新了
提供的代码是您的GitHub提供的 但是和视频上提供的不一样 ,可以说出如有点大,例如gatway那块 resource文件中有zuul和ribbon的配置 ,而您提供的代码中没有啊,可不可以提供一份呢 ,网上老师这一批大概是2018年九月份讲的这个,迫切希望您可以答复 ,谢谢大神

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.