lysyi3m / npmdc Goto Github PK

When using with Rails, npmdc should start only for server, not for console or rake tasks

Npmdc::Checker has overgrown it's functionality and is too complex. We should refactor it to make more readable and fix Rubocop offenses.

• Ignored Rubocop rules are mentioned in .rubocop.yml in the FIXME section.
• All the refactored code should be readable and covered with specs
• The code should be extracted into meaningful methods and/or classes

For projects with yarn add support for version-matching based on yarn.lock file instead of package.json-based matching.

According to official package.json documentation we need to support following "non-version" formats for dependency matching:

Git urls:

git://github.com/user/project.git#commit-ish
git+ssh://user@hostname:project.git#commit-ish
git+ssh://user@hostname/project.git#commit-ish
git+http://user@hostname/project/blah.git#commit-ish
git+https://user@hostname/project/blah.git#commit-ish

Github urls:

user/repo
user/repo#commit-ish

Local paths:

../foo/bar
~/foo/bar
./foo/bar
/foo/bar
file:../foo/bar

What do you think about restrict usage of this gem with rails apps only to development mode? It can be done by adding details about development section of Gemfile to Readme, and/or adding a check for Rails.env.development in code.

npmdc should suppress Rails process if there are any "serious" errors occurred (i.e missed packages or version mismatch errors; missed package.json file shouldn't be cricitical).

At the moment, we maintain cross Ruby and Rails tests with manually created gemfiles which is not very cozy to maintain.

• we should replace homebrew gemfiles with thoughtbot/appraisal integration
• we should mention supported Ruby and Rails version in the README file