cargo test readme fails locally about scroll HOT 8 CLOSED

And since #[cfg(doctest)] has been stabilised (in 1.40), you'll be able to do:

#[cfg(doctest)]
doctest!("../README.md");

Don't hesitate to come back to me if you find any issue. :)

from scroll.

It doesn't indeed.

from scroll.

I hit this issue too. Key:

error: extern location for scroll does not exist: /home/m4b/projects/scroll/target/debug/libscroll.rlib

cargo test runs tests/readme.rs, which depends on having first built the .rlib, and in fact one of the examples in the README uses scroll_derive. My process is now cargo build --features=derive && cargo test, which… isn't great.

from scroll.

I had to:

1. remove the rust annotation to the code fence
2. add no_test to the code fence

on the offending README example in order to get tests passing on the derive example; this is pretty undesirable state of affairs, but I don't have time to figure this out right now

from scroll.

So I disabled the readme tests in bb214ae, because I don't know what's wrong; @luser if you get a chance/have some time, and want the readme tests still running, would you mind looking into this?

from scroll.

While looking at the external docs issue I found a link to doc-comment which has a clever workaround for this so I inlined the concept and it works nicely! (Thanks @GuillaumeGomez!)

#66

from scroll.

Cool! Since it looks like @luser fix works for now, we’ll probably wait a few rustc cycles to adopt 1.40 since other upstream deps have much lower rustc requirements? Though I guess the test doesn’t effect the required rustc for building when used as a dep?

from scroll.

Awesome this is closed thank you @luser and will upgrade to doctest when the time comes : D

Thanks everyone !

from scroll.