Scroll 0.9.1 doesn't compile under Rust 1.25.0 due to i128 about scroll HOT 8 CLOSED

build.rs could automatically define a feature for the rust version and use that to enable i128 support, similar to what the rand crate does.

from scroll.

goddamnit; should i yank and publish as 0.10?

from scroll.

I broke goblin too so that's great also :/

from scroll.

Would you be interested in a PR implementing @philipc's idea? That would require adding a build.rs file, but it can follow rand's version which is pretty simple.

from scroll.

Maybe; I'd almost prefer to publish a 0.10.0 and let everyone wait until they upgrade/the new edition comes out, and then say it requires 2018; but anyway, i also don't see how that build.rs would fix things? I imagine it's more involved?

from scroll.

not sure if yanking and publishing 0.10.0 would work though; also no sure how i ever published a newer version because scroll has a circular dependency on itself, heh.

from scroll.

Ok, published 0.9.2; cranelift-faerie is compiling again, thanks to everyone helping out here!

from scroll.

Scroll requires 1.20 now; we'll remove the build script once rust 2018 edition is out, and require rust 2018

from scroll.