maanyos / pe Goto Github PK

in the loop, carparkList calls itself with filterByString, but it doesn't activate any bar

the sequence diagram here suggests the printResult is handled by parking class, but it makes more sense that Ui should handle printResult by calling itself?

The getCommand method should intuitively return a Command object, and not a printResult method call

How does the next command get parsed, if the parser reference is lost after each parseCommand? if each new command creates a new parser oobject, its not reflected

similarly for commandResult

seems like the first path in alt is already executed anyway before the entire alt frame, is there a difference between the two, or a change in system state in between that is not reflected?

why have the -address flag for filter if the default already searches for -address? developer guide doesn't mention that there are future plans for different ways of filtering, and it seems like many parts of the user guide (like the feature list and command summary) leaves out the -address flag.

how does XYZCommand class relate to the logic component?
is it different from the ABCCOmmand below?

seems like the entire input is rejected if extra whitespaces are inserted within the paramters

or at least, the response displayed does not reflect the input

There are too many moethods listed in API class , most of which are not explained in the description, and some are quite insignificant, like getters

eddae

since the entire user guide and the help message uses the term 'carpark ID', it would be more intuitive to name it 'carpark ID' as well instead of 'carpark code' when displaying the details. carpark code could mean postal code or something

i skimmed through the text file of all the carpark lots, and it seems that all (or at least majority of) the carparks don't have lots for motorcycles and heav vehicles. if most carparks have 0 lots for motorcycles and heavy vehicles, perhaps it is better not to display when the user finds it, to reduce clutter. or if the case is that the data from LTA does not specify for motorcycles and heavy vehicles, it can be removed entirely