Java format hook does not work on Java 1.8 about language-formatters-pre-commit-hooks HOT 4 CLOSED

Hi Samuele,

In the meantime on the link you have referenced there is no trace of 1.8 version.

Java 1.8 == Java 8, so it is mentioned over there.

Please look at the code in the pretty_format_java.py.

According to the google-java-format/README, the --add-exports JVM flags are required when running on JDK 16 and newer.

What needs to be done is the following.

1. check java version (there is a function for this)
2. for any versions >= 16, you add the --add-exports arguments.
3. for all versions below 16 you do not add them.

That's it. Thanks 🙂

from language-formatters-pre-commit-hooks.

I'm not a bit Java expert and I'll try to document myself a bit more.
In the meantime on the link you have referenced there is no trace of 1.8 version.
Something worth mentioning is that recent versions of Google Java Formatter might not work without the add exports, which implies that you wouldn't be able to run them on your java version.

from language-formatters-pre-commit-hooks.

Google Formatter does not start on JDK 8.
Sorry for bothering.

from language-formatters-pre-commit-hooks.

Thanks for the the report and carrying the check already.

from language-formatters-pre-commit-hooks.