Giter VIP home page Giter VIP logo

Comments (5)

macisamuele avatar macisamuele commented on June 12, 2024 2

To be clear, I'm not suggesting to use the workaround as stable solutions but rather as mitigations until a release is provided.

Your point on absent release is fair and I should have released them earlier even if there were no functional updates of the tool and I'm sorry for that.

As of now v2.13.0 has been released hence no workarounds are going to be needed.

from language-formatters-pre-commit-hooks.

macisamuele avatar macisamuele commented on June 12, 2024

Given the absence of new features I'm wondering what is the hidden ask beyond this.

Is there something that I'm missing or features that were supposed to be released on not released yet?

Please give me more information such that I can react accordingly.

from language-formatters-pre-commit-hooks.

eirnym avatar eirnym commented on June 12, 2024

These tools are released quite often. I see this important enough to release the hooks

from language-formatters-pre-commit-hooks.

macisamuele avatar macisamuele commented on June 12, 2024

I can understand and next week I'll be releasing a new version.
In the meantime:

  • hooks can be configured to use a specific commit sha from this repository (rev: {LATEST_SHA_OR_VERSION})
  • most of the pre-commit hooks allow for users to change the version of the external tool used.
    By default it does use the version defined within the release, but it can be altered with arguments like --google-java-formatter-version

from language-formatters-pre-commit-hooks.

eirnym avatar eirnym commented on June 12, 2024

I understand your point.

Sha version isn't a semver and a person needs a full commit history to tell which gir revision is created later than other one. E.g. aaaaaa could be after bbbbbb.

Specific tool versions are not a very good idea either as tools such as Dependabot or RenovateBot will never pick version automatically. I theoretically can create a hook for renovate bot, but it would be way more complicated than upgrade tools on your side with the same tools and make releases more often.

from language-formatters-pre-commit-hooks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.