Giter VIP home page Giter VIP logo

glbind's Introduction

David Reid

Open source C and C++ developer focusing on small, easy to use libraries with no dependencies and simple build systems.

discord mastodon

glbind's People

Contributors

mackron avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

glbind's Issues

Building glbind.h on Windows through MinGW mixes CRLF lines with LF lines

Since glbOpenAndReadFileWithExtraData uses "rb" mode to open files, on Windows they will retain their CR (\r).

result = glbFOpen(filePath, "rb", &pFile);

This causes a problem, because despite tinyxml2 also opening the (.xml) file in "rb" mode
FILE* fp = callfopen( filename, "rb" );

they strip the CR's before parsing
if ( (_flags & NEEDS_NEWLINE_NORMALIZATION) && *p == CR ) {
// CR-LF pair becomes LF
// CR alone becomes LF
// LF-CR becomes LF
if ( *(p+1) == LF ) {
p += 2;
}
else {
++p;
}
*q = LF;
++q;
}

So, when the tags in the template file are replaced

glbind/source/glbind_build.cpp

Lines 1698 to 1706 in bb63d02

for (size_t iTag = 0; iTag < sizeof(tags)/sizeof(tags[0]); ++iTag) {
std::string generatedCode;
result = glbBuildGenerateCode_C(context, tags[iTag], generatedCode);
if (result != GLB_SUCCESS) {
return result;
}
glbReplaceAllInline(outputStr, tags[iTag], generatedCode);
}

they have only LF line endings.

You can check this is the case by compiling and running the build code with MinGW.
Checking with git:

glbind $ git ls-files --eol
i/lf    w/crlf  attr/                   .gitignore
i/lf    w/crlf  attr/                   README.md
i/lf    w/crlf  attr/                   build/README.md
i/lf    w/crlf  attr/                   examples/01_Triangle/01_Triangle.c
i/lf    w/crlf  attr/                   examples/99_ARB_shaders/99_ARB_shaders.c
i/lf    w/crlf  attr/                   examples/99_ARB_shaders/resources/FragmentShader.txt
i/lf    w/crlf  attr/                   examples/99_ARB_shaders/resources/VertexShader.txt
i/lf    w/crlf  attr/                   examples/glbExamplesCommon.c
i/lf    w/mixed attr/                   glbind.h
i/lf    w/crlf  attr/                   resources/README.md
i/lf    w/crlf  attr/                   source/external/tinyxml2.cpp
i/lf    w/crlf  attr/                   source/external/tinyxml2.h
i/lf    w/crlf  attr/                   source/glbind_build.cpp
i/lf    w/crlf  attr/                   source/glbind_template.h

I made a fix by stripping the CR's #1

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.