madorin / matex Goto Github PK

Try to use a negative number in the equation.

5 + (-0.5) produces an error when it should result to 4.5.
5 + -0.5 produces an error when it should result to 4.5.

It would be fantastic if the project will be released under a license. I would like to use the well written code.
More Info

I have and EvalMathFunctions class, holding a 'random' function without arguments.

class EvalMathFunctions {
  static public function random() {
    return rand();
  }
}

I register this in matex:

$this->evaluator->functions = [
  'random' => ['ref' => '\\EvalMathFunctions::random', 'arc' => 0]
];

I then call the function:

$this->evaluator->execute('random()');

And get the error.

The evaluator does not support all float values example:

Equation: x - (x * y);
variables : [x=>100, y=>0.1];

function isNumer does not consider 0.1 a valid value.

I tried to multiply two values using a full width operator like ＊.
No errors or exceptions are displayed. Returns the first value as result.

Sample
22954＊100 =22954

Not entirely sure whether this is a bug or a feature request.

In my code I have:

$this->matex->execute('a=random()');

Unfortunately, this throws an exception: Exception: Unknown variable: a in Evaluator->getVariable(). Am I correct that this is not supposed to work in the current version?

Hi,

I have a problem when calculate simple sum :
$evaluator = new \Matex\Evaluator();
$evaluator->execute('0.37+0.31-0.68');

The result must be "0", but it return : "-1.1102230246252E-16"

Have you an idea of why ?

Thanks

Is your feature request related to a problem? Please describe.
I have a use case where my variables are UCased (i.e. A, B, ...). I was surprised to have to use strict Lcase variables because your Evaluator is LCasing the formula passed to it.

Describe the solution you'd like
Let the user choose the case sensitivity via an option and by default use the exact formula that the user provides (no LCasing).
OR
LCase all variables passed to the evaluator (this one is not my favorite).

Describe alternatives you've considered
N/A

Additional context
N/A.

Is your feature request related to a problem? Please describe.
Currently its not possible to round

Describe the solution you'd like
Will be awesome if there is a way to use it that way for example i want to do round(0.7/100) or something else..

Describe alternatives you've considered
Currently im using plain php, will like to switch to a lib like this so i can create dynamic calculations via user inputs for example.

Additional context
Is there any alternative package to this that supports round? I couldn't find any maybe im searching the wrong keywrods.

Is your feature request related to a problem? Please describe.
This feature request is related to a use case. I need to implement price calculation depending on some variables. A price can be obtained through various formula. Each formula has a condition of application (e.g a+b+c > 200 then use formula 1 - I need to be able to evaluate the formula a+b+c > 200)

Describe the solution you'd like
Take the comparison operators into account.

Describe alternatives you've considered
N/A

Additional context
N/A.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Describe the bug
The order of operations between powers and multiplications is not what I expect

To Reproduce
Steps to reproduce the behavior:

$evaluator = new \Matex\Evaluator();
$evaluator->execute(4*3^2); // returns 144
$evaluator->execute(45/3^2); // returns 225

Expected behavior
Following usual PEDMAS order of operations, powers should be computed before multiplications and/or divisions.
The above code should then return 36 on line 2 and 5 on line 3

Describe the bug
Unmatched brackets exception for a simple string concatenation.

To Reproduce
Steps to reproduce the behavior:
execute('"(" + "xyz"')

Expected behavior
execute function tests for unmatched brackets but does not ignore brackets within a "string" - bracket checking should occur per expression parsed.

Screenshots
n/a

Desktop (please complete the following information):
n/a

Smartphone (please complete the following information):
n/a

Additional context
Add any other context about the problem here.

This is only a suggestion, but I needed time to understand examples. I suggest you to remove the object requirement. For function example :

function sum() {
$arguments = func_get_args();
$result = 0;
foreach ($arguments as $argument)
$result += $argument;
return $result;
}
$evaluator = new \Matex\Evaluator();
$evaluator->functions = [
'sum' => ['ref' => 'sum', 'arc' => null]
];
echo $evaluator->execute('sum(1, 2, 3)');

My PHP Version is 7.2.34 and composer is not installing it.

What's the PHP version that it needs?

Adding a number and a string now produces a php warning.

e.g.:

$evaluator = new \Matex\Evaluator();

try {
    $evaluator->execute('1 + "x"');
} catch(Exception $exception) {
    // ....
}

It would be nice to have a catchable exception when the terms do not match and the calculation is invalid.

Describe the bug
( 101.25 + -202.44 ) = syntax error

To Reproduce

$evaluator = new \Matex\Evaluator();
$error = FALSE;
try {
	$val = $evaluator->execute("( 101.25 + -202.44 )");
} catch ( \Exception $e ) {
	$error = $e->getMessage();
	$val = "__";
}
echo $val;
echo $error;

Expected behavior
return -101.19 and not error out

Desktop (please complete the following information):

• OS: windows 10. php 7.2

So every time it executes an equation with zeros mostly, it doesn't work. If I execute just '10' it will give me just the multiplication of 10 ( so 1 for 10, 2 for 20 ) and that's all. Also, getting floats like 0.5 into the equation will give an error. So there's a problem whenever 0 is present.

I'd like to have a modulo operator, but I would generalise and say it would be nice if we could add custom functions which behave like the basic operators, that being that you call them like a op b instead of op(a, b).

static function sum($arguments) {
	$result = 0;
	foreach ($arguments as $argument)
		$result += $argument;
	return $result;
}

$evaluator = new \Matex\Evaluator();
$evaluator->functions = [
	'sum' => ['ref' => '\\Space\\Class::sum', 'arc' => null]
];
echo $evaluator->execute('sum(1, 2, 3)');

In the function sum, when I output $arguments, I only get the first value (1, in this case).
How do I get array of all the arguments?

Is your feature request related to a problem? Please describe.
This project looks really handy, but without having it on https://packagist.org/ it makes installing and maintenance very old school. E.g. my current laravel project I have to download the files and manually autoload them.

Describe the solution you'd like
Please can you add a composer.json file to the project and submit the project to https://packagist.org/ This would allow for easier installation and maintenance, when used inside other projects.

Describe alternatives you've considered
There ain't one

Additional context