Comments (4)
Native PHP curl functions can be considered as low-level functionality. Magento provides native high-level adapters (e.g. Varien_Http_Adapter_Curl) for handling curl requests.
from coding-standard.
Hm but what about "require_once" that gives me error "statement detected. File manipulations are discouraged. Concatenating is forbidden."?
The function is used then overriding controllers.
For example
require_once Mage::getModuleDir('controllers', 'Mage_Checkout') . DS . 'OnepageController.php';
from coding-standard.
Hey,
You're absolutely right, Magento autoloader doesn't work with controllers, so we have to use 'include' constructs. As every static analysis tool, our tool may yield some false positives.
Thanks for reporting this issue, I'll ensure it's handled in the next release.
from coding-standard.
Fix committed. Now the sniffer doesn't produce an issue when including a controller class.
from coding-standard.
Related Issues (20)
- Error Functions HOT 1
- exception thrown in /usr/share/php/PHP/CodeSniffer.php HOT 2
- something bad in file_exists? HOT 1
- Warning message for non-plugin class HOT 2
- Can't use EcgM2 with composer HOT 8
- Referenced sniff "Generic.PHP.Syntax" does not exist
- Can you please do more frequest releases? HOT 3
- Coding Standard Clarification HOT 1
- "Plugin beforeSave function should have at least two" HOT 2
- Magento 1.x - Performance Loop Sniff HOT 1
- False positives with NamespaceSniff HOT 2
- Shall we folllow the official coding standards? HOT 1
- Fatal error - interface `PHP_CodeSniffer_Sniff` not found when using PHPCS 3.0.0-RC4 HOT 8
- Why is parse_url forbidden? HOT 5
- Can someone explain to me what is bad about a good use of call_user_func(_array) HOT 2
- tempnam alternative to create temporary files - M1 HOT 1
- php code sniffer not working in windows 8.1 xampp , php version 5.6 HOT 1
- Empty diff HOT 2
- Uncaught TypeError: vsprintf(): Argument #2 ($values) must be of type array, string given in vendor/squizlabs/php_codesniffer/src/Files/File.php:1056 HOT 3
- Internal error fo do...while
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coding-standard.