magicmau / elitejournalreader Goto Github PK

"EliteG19s\SharedAssemblyInfo.cs" doesn't seem to be part of the project.

Compilation fails because of that entry.

Will EliteJournalReader be updated "in the near future"?

I would love to see the new events implemented and specifically ProspectedAsteroid event (§11.33) is one i would like to play with.

https://forums.frontier.co.uk/forums/elite-api-and-tools/ contains the current version of Elite:Dangerous Player Journal manual as y'all probably know.

ShipId should be NewShipID

8.48 ShipyardNew

When written: after a new ship has been purchased

Parameters:
ShipType
NewShipID

Example: { "timestamp":"2016-07-21T14:36:38Z", "event":"ShipyardNew", "ShipType":"hauler", "NewShipID":4 }

Not really an issue just some missing fields in a couple of events;

Event MaterialCollectedEventArgs is missing a string called Name_Localised
Event MiningRefinedEventArgs is missing a string called Type_Localised

If you create two journalWatchers then they will recieve each others events.

Using a shared static list of events means two independent journalwatchers end up recieving each other events.

In real-life people will only create one watcher and point it at %PROFILE%\Saved Games\Frontier Developments\Elite Dangerous

However confused the hell out of me when unit tests get run in parrallel.

This strikes me as a classic 'has a' vs 'Is a' design issue.

Having checked through the code the only thing that "breaks" is that the void Parse(string line) method (ab)uses the FileSystemWatchers OnError method to indicate that errors have occoured either parsing the json or in an external eventhandler processing the event ( we probably out to separate out those two cases ).

By inheriting from FileSystemWatcher you expose its internals to consumers of JournalWatcher, changes to these properties are more likely to break JournalWatcher functionality than allow consumers enhance their experience.

Hiding the FSW inside makes potentially things less complicated for consumers.

I think
public string Influence;
is missing in MissionCompletedEvent.cs after line 71 in the
public struct FactionInfluenceEffect

when using the dll in app, the dll don't pick up when you quit the game, and start it again, since there's a new file written etc

It would be useful for consumers if the JournalWatcher had an interface it implimented to allow it to be faked/mocked or susbstiuted using InversionOfControl.

Can you confirm that it is a typo in the above enum for the entry "Unfriendly"? Should it be -1 and not 1?

Is it possible to read active mission details like the needed amount of cargo from previous sessions? It looks like the missions.json file doesnt provide this info. Its only part of new mission events.

Hi just wondering if there's an update in progress?

Cheers :)

Dear @MagicMau,

I like your little masterpiece you created here. I have only one question: Is there an event for the landing gear (deployed, retracted)? I couldn't find this event in the event list...

Hi,

I was wondering if you could add some usage code example for the Status Watcher to the ReadMe file, I have mastered the Journal Watcher finally but can't seem to link the "StatusFileEvent" to a handle.

Thanks in advance.

Handle the journal event telling us that a new navroute has been written to NavRoute.json

Ideally internally consume the journalevent and then parse the json file and trhow/fire a new event based on the contents.