Fail to edit the commit message when a secondary worktree is inside a symlinked directory about magit HOT 4 CLOSED

I'm closing this now, but will reopen once you can find steps that would allow us to reproduce this issue.

from magit.

To reproduce, you could use the following steps:

I tried to capture those steps in the script below.

#!/bin/sh

set -eu

root=$(mktemp -d root-XXXX)

mkdir "$root"/parent
ln -s parent "$root"/link

repo=$root/parent/repo

git init -q "$repo"
git -C "$repo" commit -q --allow-empty -mc1
git -C "$repo" commit -q --allow-empty -mc2

git -C "$repo" worktree add -q ../worktree

wtree="$root"/parent/worktree
printf 'foo\n' >"$wtree/foo"
git -C "$wtree" add .

export PS4='$ '
set -x

ls -1 "$root"
ls -1 "$root"/parent
stat -c %N "$root"/link
ls -1 "$root"/link
git -C "$wtree" status -s

resulting state:

$ ls -1 root-1fiW
link
parent
$ ls -1 root-1fiW/parent
repo
worktree
$ stat -c %N root-1fiW/link
'root-1fiW/link' -> 'parent'
$ ls -1 root-1fiW/link
repo
worktree
$ git -C root-1fiW/parent/worktree status -s
A  foo

I then visited root-*/link/worktree with Emacs and was able to commit the staged change via Magit.

That's with the current tip of main (2b02bfb), Emacs 29.1, and a vanilla configuration on a GNU/Linux system. I also tried with the commit you referenced (51eaa9f).

Does the above script capture the setup you're describing? If not, could you suggest the changes required for it to reproduce the issue?

Also, have you confirmed that you can commit from the command line when in the link/worktree directory (e.g., git commit -m blah)?

from magit.

@kyleam Thank you for helping me with the issue. I will examine the reproduction steps to correctly understand my problem.

from magit.

As @kyleam pointed out, there is no error that occurs within the reproduction steps above. The issue does remain, but I don't know exact reproduction steps. I'll update this ticket if I find some more information.

from magit.