magmaguy / freeminecraftmodels Goto Github PK

CommandHandler.java is missing a check to see if the executor is actually a player resulting in

fmm spawn static
[12:36:03 WARN]: java.lang.ClassCastException: class com.destroystokyo.paper.console.TerminalConsoleCommandSender cannot be cast to class org.bukkit.entity.Player (com.destroystokyo.paper.console.TerminalConsoleCommandSender and org.bukkit.entity.Player are in unnamed module of loader java.net.URLClassLoader @5ce65a89)
[12:36:03 WARN]: at FreeMinecraftModels.jar//com.magmaguy.freeminecraftmodels.commands.CommandHandler.lambda$constructCommands$5(CommandHandler.java:85)
[12:36:03 WARN]: at FreeMinecraftModels.jar//cloud.commandframework.execution.CommandExecutionHandler.executeFuture(CommandExecutionHandler.java:95)
[12:36:03 WARN]: at FreeMinecraftModels.jar//cloud.commandframework.execution.CommandExecutionCoordinator$SimpleCoordinator.coordinateExecution(CommandExecutionCoordinator.java:123)
[12:36:03 WARN]: at FreeMinecraftModels.jar//cloud.commandframework.CommandManager.executeCommand(CommandManager.java:188)
[12:36:03 WARN]: at FreeMinecraftModels.jar//cloud.commandframework.bukkit.BukkitCommand.execute(BukkitCommand.java:116)
[12:36:03 WARN]: at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:155)
[12:36:03 WARN]: at org.bukkit.craftbukkit.v1_20_R1.CraftServer.dispatchCommand(CraftServer.java:987)
[12:36:03 WARN]: at org.bukkit.craftbukkit.v1_20_R1.CraftServer.dispatchServerCommand(CraftServer.java:972)
[12:36:03 WARN]: at net.minecraft.server.dedicated.DedicatedServer.bf(DedicatedServer.java:500)
[12:36:03 WARN]: at net.minecraft.server.dedicated.DedicatedServer.b(DedicatedServer.java:447)
[12:36:03 WARN]: at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:1393)
[12:36:03 WARN]: at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1170)
[12:36:03 WARN]: at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:317)
[12:36:03 WARN]: at java.base/java.lang.Thread.run(Thread.java:840)
[12:36:03 INFO]: [Example] An internal error occurred while attempting to perform this command.

Hello and thank you for your work on this and other plugins!

I am trying to integrate FMM to my plugin, but I get dependency error

[ERROR] Failed to execute goal on project BCPlugin: Could not resolve dependencies for project ing.bananacraft:BCPlugin:jar:1.0-SNAPSHOT: Failed to collect dependencies at com.magmaguy:FreeMinecraftModels:jar:1.1.2-SNAPSHOT -> com.magmaguy:EasyMinecraftGoals-dist:jar:1.7.0: Failed to read artifact descriptor for com.magmaguy:EasyMinecraftGoals-dist:jar:1.7.0: The following artifacts could not be resolved: com.magmaguy:EasyMinecraftGoals-manager:pom:1.7.0 (absent): Could not find artifact com.magmaguy:EasyMinecraftGoals-manager:pom:1.7.0 in ossrh-releases (https://s01.oss.sonatype.org/content/repositories/releases/)

in my pom.xml I added

<dependency>
      <groupId>com.magmaguy</groupId>
      <artifactId>FreeMinecraftModels</artifactId>
      <version>1.1.2-SNAPSHOT</version>
      <scope>provided</scope>
</dependency>

and also figured out to add this

<repository>
    <id>ossrh-releases</id>
    <url>https://s01.oss.sonatype.org/content/repositories/releases/</url>
</repository>
<repository>
    <id>ossrh</id>
    <url>https://s01.oss.sonatype.org/content/repositories/snapshots/</url>
</repository>

without these, maven was looking for the dependencies in ...spigotmc.org/nexus...

As I see, it tries to resolve EasyMinecraftGoals-manager dependency, but there is no manager on sonatype.

Please help me to integrate this with my plugin, I am really excited to test it out 😊

P.S.

Maven also tries to download other dependencies of FMM, like net/kyori and so on. It that correct? And should I provide additional repositories for that or is there a way to skip all these additional dependencies?