Using outdated counts when running counter_culture_fix_counts? about counter_culture HOT 7 OPEN

This problem is much reduced with a927a23; that commit makes sure we pull both the correct and incorrect counts in one query. However, any additions / deletions between then and the later update would still cause a disparity. In any case, we are certainly better off.

from counter_culture.

Would changing it to do an update_all with a JOIN help out with #79 at all?

Even though that issue was closed, it is actually still a pressing issue for me and I haven't found a suitible solution yet.

from counter_culture.

@xtagon I'm not sure what you mean to be honest.

from counter_culture.

Maybe we can use an update_all with a JOIN to let the database handle this atomically? Might this also be faster?

@magnusvk I was hoping this meant counter_culture_fix_counts would be faster in that case

from counter_culture.

@xtagon it uses update_all: https://github.com/magnusvk/counter_culture/blob/master/lib/counter_culture/reconciler.rb#L118

from counter_culture.

@magnusvk Yes it does, but it does 1 update_all per primary key, so it's effectively a singular update.

In the end I was able to do a single update_all to compute counts for a table of millions of records in under a minute, but my use case is very simplified compared to what counter_culture supports so I can see how that would be hard to add to the library (with things like soft deletion, advanced associations, etc.)

from counter_culture.

Great, glad you could get it resolved. :)

from counter_culture.