maikuolan / common Goto Github PK

As title, according to the CONTRIBUTING guide, we should consider adding coding style tool to check PSR-2 coding style automatically.

There're two popular coding style tool on PHP.

One is PHP_CodeSniffer and another one is PHP-CS-Fixer.

@Maikuolan, do you have any suggestion or idea about this :)?

I'm going to add a request class to the package some time later tonight or tomorrow thereabouts (both v1 and v2). I wouldn't mind adding some proxy options to it at some point, and that would be pretty easy to do too, but the necessary curl_setopt options weren't added until PHP 7.3, and the minimum PHP version requirement for v2 (the package's current major version) is PHP 7.2, which means these proxy options wouldn't be backwards-compatible with the minimum PHP version requirement for any of the package's existing major versions, so I'm putting the proxy idea on the backburner for now, until I eventually get around to releasing a new major version (most likely v3) with a PHP minimum version requirement of at least PHP 7.3 or higher (no particular date or schedule planned for this right now though). Since I haven't planned any particular date or schedule for this yet, there's a good chance I probably would've forgotten about this by then, so creating this issue as a future reminder for it. '^.^

References:

• https://www.php.net/curl_setopt
• https://stackoverflow.com/questions/5211887/how-to-use-curl-via-a-proxy
• CIDRAM/CIDRAM#186 (comment)

When I initialize the L10N test on PR #3, I found the following issue:

Consider the L10N::getPlural method and we can find the $Choices variable in this method.

This $Choices variable seems that it's from the $Data or Fallback variables and they can accept the array with multiple rules.

This will be the problem when assigning the array to $Data and $Fallback variables.

The second parameter in method_exists method only accepts the string type, not array type.

@Maikuolan, you should consider this and let the getPlural method can find the current rule in $Choices array and the constructor can also accept the $Data and Fallback with multiple rules array.

Need to add information to the readme to describe how to properly use the package and its classes.

Need to write unit tests for the currently available classes.

How do i edit a YAML file?

I have tried: $Object->Data['foo'] = 'bar';

but it dont work for me.

As title, I think it's time to drop php-5.x supports because these versions has been deprecated for about long time.

We should let this package require php-7.1 version at least.