Passing nil/empty bcc parameter is transformed to array with blank string about mailgun-ruby HOT 6 CLOSED

@nholden Very nice catch. I'll get this into a bug fix release as soon as I can. Thanks!

from mailgun-ruby.

Sorry about that! I will look into it and fix it up on Monday!

from mailgun-ruby.

@pirogoeth I started to look into this myself. An easily solvable blocker is that Rails isn't listed a dev dependency in the gemspec. Is there any reason why and if not, is there a minimum version of Rails that should be supported? I couldn't find any reference in the repo.

from mailgun-ruby.

@KnownSubset I didn't pin Rails into the gemspec since I packaged Railgun into the same gem. A solution would be to split Railgun into a separate repo but I do not see much benefit to that. In my railgun-sample application I have rails >= 5.0.0.1 as the minimum dependency.

Any recommendations on how to handle this?

from mailgun-ruby.

I ran into this error message as well when I tried to configure a Rails app to use the :mailgun ActiveMailer delivery method. It looks like there's some code in Railgun that tried to anticipate this, but I'm not sure it's working as intended.

# reject blank values
message.delete_if do |k, v|
  v.nil? or (v.respond_to?(:empty) and v.empty?)
end

For a message that includes { cc: [''] }, that blank value won't be rejected. First, [''].respond_to?(:empty) will return false (I think it should be respond_to(:empty?)). Even then, we'd need to ignore the empty string, since [].empty? is true, but [''].empty? is false.

Could we try something like this?

# reject blank values
message.delete_if do |k, v|
  v.nil? || (v.is_a?(Array) && v.reject(&:empty?).empty?)
end

from mailgun-ruby.

Hi, has there been a release yet where this is included?

from mailgun-ruby.