Giter VIP home page Giter VIP logo

Comments (11)

pirogoeth avatar pirogoeth commented on July 29, 2024 1

@rmcsharry Awesome! I'll cut an official release on Monday :)

from mailgun-ruby.

pirogoeth avatar pirogoeth commented on July 29, 2024

@rmcsharry I'm assuming this is with the new Railgun code / version 1.1.4 of the gem?

from mailgun-ruby.

rmcsharry avatar rmcsharry commented on July 29, 2024

Yes - mailgun-ruby (1.1.4). I also tested with Postman and the filename there shows up as 'pd_mime_attachment'.

So it seems both gmail and postman see that the filename is empty and substitute a default value.

I suppose it could be ActionMailer doing this, but then surely Stack Overflow would be swamped with questions about this? It used to happen in Rails 3. I've opened a question anyway for Rails 5 to see if anyone else has seen this in ActionMailer specifically.

from mailgun-ruby.

pirogoeth avatar pirogoeth commented on July 29, 2024

@rmcsharry I will look in to this, it very well could be an issue with Railgun. I'll let you know what I find :)

from mailgun-ruby.

pirogoeth avatar pirogoeth commented on July 29, 2024

@rmcsharry I think I found the issue. Stand by for a PR.

from mailgun-ruby.

rmcsharry avatar rmcsharry commented on July 29, 2024

@pirogoeth Awesome, thanks for the quick fix. I just tested it and it works! :)

from mailgun-ruby.

rmcsharry avatar rmcsharry commented on July 29, 2024

@pirogoeth This branch I tested was labelled as version 1.1.5. But now that you have merged it, the version of master branch did not change, it is still 1.1.4 - was that the intention?

from mailgun-ruby.

pirogoeth avatar pirogoeth commented on July 29, 2024

@rmcsharry It seems that 1.1.5 has been released to Rubygems and 1.1.5 is in master (tagged as v1.1.5)..

from mailgun-ruby.

rmcsharry avatar rmcsharry commented on July 29, 2024

Ok thanks I just removed it from my project and bundle installed again, now it shows up as 1.1.5. Thanks for confirming!

from mailgun-ruby.

pirogoeth avatar pirogoeth commented on July 29, 2024

Of course!

from mailgun-ruby.

pavanscs avatar pavanscs commented on July 29, 2024

new issues can any one please help me with this i want a attachment file that was send to the mailer has to be open in a new tab is it possible to make the pdf file to open in a new tab

from mailgun-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.