makersacademy / airport_challenge Goto Github PK
View Code? Open in Web Editor NEWFly!
License: Other
Fly!
License: Other
A guide to code review of the airport challenge for use by students reviewing each others code
Google Form to allow reviewers to mark issues they find so coaches can aggregate the results and know which areas to cover in more detail
form needs to switch over to positive tone and match new rubric hyperlinks etc.
I wasnt sure where to open this - it is more general config than airport challenge specific.
Following the contributing.md guidelines I set up Travis CI on my repo
https://github.com/olwend/airport_challenge
https://travis-ci.org/olwend/airport_challenge
It appears to be running rspec tests but has disabled Coveralls and coverage is showing at 100% across board.
Can you tell me how to reinstate coveralls?
Thanks
__{"message":"Couldn't find a repository matching this job.","error":true}�[0m__
�[33m[Coveralls] Submitting with config:�[0m �[33m{ "environment": { "pwd": "/home/travis/build/olwend/airport_challenge", "rails_root": null, "simplecov_root": "/home/travis/build/olwend/airport_challenge", "gem_version": "0.7.9", "travis_job_id": "190061421", "travis_pull_request": "false" }, "git": { "head": { "id": "b3a479e9c3429c327607364f9eea44ba50010396", "author_name": "olwend", "author_email": "[email protected]", "committer_name": "olwend", "committer_email": "[email protected]", "message": "Errors for airport stormy or full added" }, "branch": "(detached from b3a479e)", "remotes": [ { "name": "origin", "url": "https://github.com/olwend/airport_challenge.git" } ] }, "service_job_id": "190061421", "service_name": "travis-ci" }�[0m �[36m[Coveralls] Submitting to https://coveralls.io/api/v1�[0m �[31mCoveralls encountered an exception:�[0m �[31mRestClient::UnprocessableEntity�[0m �[31m422 Unprocessable Entity�[0m �[31m/home/travis/build/olwend/airport_challenge/vendor/bundle/ruby/2.2.0/gems/rest-client-1.7.2/lib/restclient/abstract_response.rb:48:in
return!'�[0m
�[31m/home/travis/build/olwend/airport_challenge/vendor/bundle/ruby/2.2.0/gems/rest-client-1.7.2/lib/restclient/request.rb:495:in process_result'�[0m �[31m/home/travis/build/olwend/airport_challenge/vendor/bundle/ruby/2.2.0/gems/rest-client-1.7.2/lib/restclient/request.rb:421:in
block in transmit'�[0m
�[31m/home/travis/.rvm/rubies/ruby-2.2.3/lib/ruby/2.2.0/net/http.rb:853:in start'�[0m �[31m/home/travis/build/olwend/airport_challenge/vendor/bundle/ruby/2.2.0/gems/rest-client-1.7.2/lib/restclient/request.rb:413:in
transmit'�[0m
�[31m/home/travis/build/olwend/airport_challenge/vendor/bundle/ruby/2.2.0/gems/rest-client-1.7.2/lib/restclient/request.rb:176:in execute'�[0m �[31m/home/travis/build/olwend/airport_challenge/vendor/bundle/ruby/2.2.0/gems/rest-client-1.7.2/lib/restclient/request.rb:41:in
execute'�[0m
�[31m/home/travis/build/olwend/airport_challenge/vendor/bundle/ruby/2.2.0/gems/coveralls-0.7.9/lib/coveralls/api.rb:24:in post_json'�[0m �[31m/home/travis/build/olwend/airport_challenge/vendor/bundle/ruby/2.2.0/gems/coveralls-0.7.9/lib/coveralls/simplecov.rb:72:in
format'�[0m
�[31m/home/travis/build/olwend/airport_challenge/vendor/bundle/ruby/2.2.0/gems/simplecov-0.9.1/lib/simplecov/result.rb:46:in format!'�[0m �[31m/home/travis/build/olwend/airport_challenge/vendor/bundle/ruby/2.2.0/gems/simplecov-0.9.1/lib/simplecov/configuration.rb:158:in
block in at_exit'�[0m
�[31m/home/travis/build/olwend/airport_challenge/vendor/bundle/ruby/2.2.0/gems/simplecov-0.9.1/lib/simplecov/defaults.rb:54:in call'�[0m �[31m/home/travis/build/olwend/airport_challenge/vendor/bundle/ruby/2.2.0/gems/simplecov-0.9.1/lib/simplecov/defaults.rb:54:in
block in <top (required)>'�[0m
�[31m{"message":"Couldn't find a repository matching this job.","error":true}�[0m
travis_time:end:002a9c5a:start=1483906666931429255,finish=1483906667759212351,duration=827783096
�[0K
�[32;1mThe command "bundle exec rspec spec" exited with 0.�[0m
Done. Your build exited with 0.`
@tansaku @MihaiLiviuCojocar @nikeshashar G'Morning guys, just wanted to let you know that Hound throws an error when quoting strings with single quotes and Rubocop when using double quotes, I'll continue to see if there's a solution to please both of them.
Also my code is very badly designed but I'll refactor this weekend.
Could do with some doubles, but I'm pretty sure I didn't submit mine with any either 😆
Originally posted by @charlie-casserly in #2109 (comment)
User stories need to be consistent with the code we are expecting the students to write.
I have deleted the repository associated with that pull request, so it is not longer valid.
Apologise for the inconvenience.
we have modified the rubric style over the course of the last six weeks in terms of tone of voice and a few extra components such as progress checking, and so we should bring our earlier rubrics into line with that
to make it easy to run coverage reports locally
Creating issue for this PR so it is discoverable: #1569
Ewe ants
Feedback from students suggested they would like more clarity on the requirements or their code
Wtf is right
for anyone else with this issue - incase it gets lost in slack (thnx sarah)
add this to the .travis.yml file (its a hidden file in the airport_challenge folder)
rvm: 2.2.3
There are some tweaks we should pull in from changes to the other challenges ...
Also should check if hound finally upgraded rubocop
coaches agreed this should happen before friday
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.