process feedback from code reviews about rps-challenge HOT 5 CLOSED

@Irina brought up the issue about feature tests written like unit tests with one expect per it block that she saw in Deon's code - we removed that element from the review? should re-introduce

from rps-challenge.

TODO

• fix links
• consider more mixing of who gives review (mentor-mentee or assign random pairs?)
• add a "how far did they get" section
• help juniors understand requirements before they start? --> high level requirements checklist in README?
• add back in the issue for avoiding feature tests looking like unit tests that Irina mentioned?
• make clear how students can get follow up support with coaches
• work out a way to get more feedback from juniors (check feedback channel? another survey)

from rps-challenge.

my thoughts on changes for next cycle:

• Update all challenge Rakefiles to work well with coveralls report
• Update all challenge READMEs to make high level objectives clear
  • (and make specific point about crediting any work you copied)
• all challenge review forms (and rubrics) need checking for tone of voice (positives/negatives etc.)
  • update first forms/rubrics with learnings from later ones

from rps-challenge.

also take into account: https://docs.google.com/a/makersacademy.com/forms/d/14k5geExpR8E7U14_mJXRUK3F8IXchq-__TQfaeZxc9c/viewanalytics

from rps-challenge.

Other suggestions - not sure if we want all:

• exemplar code review
• free text boxes at end of every field
• consistent positive voice
• rotating junior/senior review partners? (+++)
• encourage: "Make regularly commits after each user story to document the progress of the challenge"

from rps-challenge.