makersacademy / rps-challenge Goto Github PK
View Code? Open in Web Editor NEWCreate the Rock Paper Scissors Game
License: Other
Create the Rock Paper Scissors Game
License: Other
Had to slightly modify files above to pass automated tests. I can see that it is a common issue in our cohort :)
this will make analysis in future easier, and it allows students to get test coverage stats locally with relative ease
On each of the pull requests, there seems to be a lot of the same messages:
Some files could not be reviewed due to errors:
.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should b...
It would appear that Rubocop has introduced changes to how it's 'cops' are categorised and hence the messages. Hound is therefore using a different version of Rubocop to the one listed in the Gemfile.
To fix this I have taken the following steps:
bundle update rubocop
bundle install
(to make sure the dependencies are updated)gem install mry
mry .rubocop.yml
(these steps update the config file with the new options that were changed)It was at this point I realised Hound isn't even using the latest version of Rubocop so I have fixed the Rubocop version at 0.51.0 and repeated the process. I have no warnings locally and no error messages on my pull request.
Does this sound correct? I don't seem to have any feedback from Hound at all.
Tried to follow the method suggested, but found that my rspec tests failed. Then, I found that adding Player.players
to the method add_player
led to the tests passing. Perhaps this is a requirement in order to have an empty hash to which players can be added. Is this a problem with the code review rubric?
Would be great to automate this
Not a big deal... just a minor glitch.
In the quote;
As a marketeer
So that I can see my name in lights
I would like to register my name before playing an online game
...the word 'in' on the 3rd line is colored in red due to the shell script syntax associated.
Has caused a few people to look too deeply into its meaning.
close old challenges (could be automated?) and check CI/README etc.
from the seniors
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.