makersacademy / rps-challenge Goto Github PK

View Code? Open in Web Editor NEW

9.0 18.0 2.0K 97 KB

Create the Rock Paper Scissors Game

License: Other

Ruby 41.02% Shell 58.98%

rps-challenge's Introduction

RPS Challenge

Instructions

Feel free to use google, your notes, books, etc. but work on your own
If you refer to the solution of another coach or student, please put a link to that in your README
If you have a partial solution, still check in a partial solution
You must submit a pull request to this repo with your code by 9am Monday morning

Task

Knowing how to build web applications is getting us almost there as web developers!

The Makers Academy Marketing Array ( MAMA ) have asked us to provide a game for them. Their daily grind is pretty tough and they need time to steam a little.

Your task is to provide a Rock, Paper, Scissors game for them so they can play on the web with the following user stories:

As a marketeer
So that I can see my name in lights
I would like to register my name before playing an online game

As a marketeer
So that I can enjoy myself away from the daily grind
I would like to be able to play rock/paper/scissors

Hints on functionality

the marketeer should be able to enter their name before the game
the marketeer will be presented the choices (rock, paper and scissors)
the marketeer can choose one option
the game will choose a random option
a winner will be declared

As usual please start by

Forking this repo
TEST driving development of your app

You may find this guide to setting up a new Ruby web project helpful.

Bonus level 1: Multiplayer

Change the game so that two marketeers can play against each other ( yes there are two of them ).

Bonus level 2: Rock, Paper, Scissors, Spock, Lizard

Use the special rules ( you can find them here http://en.wikipedia.org/wiki/Rock-paper-scissors-lizard-Spock )

Basic Rules

Rock beats Scissors
Scissors beats Paper
Paper beats Rock

In code review we'll be hoping to see:

All tests passing
High Test coverage (>95% is good)
The code is elegant: every class has a clear responsibility, methods are short etc.

Reviewers will potentially be using this code review rubric. Referring to this rubric in advance may make the challenge somewhat easier. You should be the judge of how much challenge you want this at this moment.

Notes on test coverage

Please ensure you have the following AT THE TOP of your spec_helper.rb in order to have test coverage stats generated on your pull request:

require 'simplecov'
require 'simplecov-console'

SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
  SimpleCov::Formatter::Console,
  # Want a nice code coverage website? Uncomment this next line!
  # SimpleCov::Formatter::HTMLFormatter
])
SimpleCov.start

You can see your test coverage when you run your tests. If you want this in a graphical form, uncomment the HTMLFormatter line and see what happens!

rps-challenge's People

Contributors

Stargazers

Watchers

Forkers

kevinlanzon erikagriffin vvirgitti jjnewman eddbrown loris-fo wardymate c-christenson tstrothjohann guidovitafinzi tomcoakes meads58 rizali katebeavis sphaughton gabemaker louisebeh veliancreate-zz tommasobratto costassarris pau1fitz tansaku gbouffard gjmcgowan paulwallis42 armi1189 phoebehugh kanishkwalia nadav-rosenberg jflm augustinas gwasanaethau jadeking danblakeman joejknowles munded icicleta rbgeomaticsrob saramoohead bk8296 massud sanjsanj jaymuk m1lena maciejk77 domaro sjmog rodcul alexhandy1 curlygirly andygout mollies dwatson62 danwhitston ashcode09 smarbaf zanetton annakl uzomao ptolemybarnes charliekenny timoxman silvabox zdajani leggsimon gerard-morera katewilkinson arnottmj lroliphant jonathanngkh elinnet massimilianomura duskyshelf natstar93 datamineruk theoleanse kfcrobbie aleckz jackhalltipping cwgmiller harxy salman-karim ka-tsu-ra gabyml fadi-hakim emily-jane richgeog squarebe 7091laps christopheralcock giusepped katylouise richardcharman tealpaintedduck adrianw1832 joshuatatterton benja2208 dregules leon-wee sivanpatel

rps-challenge's Issues

Hound spam on pull requests

On each of the pull requests, there seems to be a lot of the same messages:

Some files could not be reviewed due to errors:

.rubocop.yml: Style/IndentationConsistency has the wrong namespace - should b...

It would appear that Rubocop has introduced changes to how it's 'cops' are categorised and hence the messages. Hound is therefore using a different version of Rubocop to the one listed in the Gemfile.

To fix this I have taken the following steps:

bundle update rubocop
bundle install (to make sure the dependencies are updated)
gem install mry
mry .rubocop.yml (these steps update the config file with the new options that were changed)

It was at this point I realised Hound isn't even using the latest version of Rubocop so I have fixed the Rubocop version at 0.51.0 and repeated the process. I have no warnings locally and no error messages on my pull request.

Does this sound correct? I don't seem to have any feedback from Hound at all.

Rps

prep for new challenge release

close old challenges (could be automated?) and check CI/README etc.

Create challenge review form for RPS

Distribute RPS feedback to students

Would be great to automate this

Review doc makes reference to rspec-sinatra

The review document makes reference makes reference to rspec-sinatra here.

Is it possible to remove/reword this section as rspec-sinatra does not currently work for Ruby 2.4.0+ (see here).

update to support coveralls report

this will make analysis in future easier, and it allows students to get test coverage stats locally with relative ease

.travis.yml and .rubocop.yml

Had to slightly modify files above to pass automated tests. I can see that it is a common issue in our cohort :)

process feedback from code reviews

from the seniors

Some of the links not working
For the general process, I thought it may be useful for juniors to get code review from different people like we pair with different people to experience different approach.
One idea is that seniors review junior's pair partner's code. Then each week juniors can get reviews from different people.
Dead link for this point "Not initializing capybara/ spec_helper correctly"
it was fine but as before there wasn't a great deal of code to review so much of the form wasn't relevant. maybe need a "how far did they get?" section at the beginning?
Broken links.
Yes
Yes, very useful guide.
The form is very helpful. The only comment is I am not sure juniors know all the requirements before they start the challenge (like to have screenshots in README, etc).
Yes very useful.

Under ‘Use of Global Variables’ in review.md

Tried to follow the method suggested, but found that my rspec tests failed. Then, I found that adding Player.players to the method add_player led to the tests passing. Perhaps this is a requirement in order to have an empty hash to which players can be added. Is this a problem with the code review rubric?

Minor error on markdown syntax

Not a big deal... just a minor glitch.

In the quote;
As a marketeer
So that I can see my name in lights
I would like to register my name before playing an online game

...the word 'in' on the 3rd line is colored in red due to the shell script syntax associated.
Has caused a few people to look too deeply into its meaning.