Didn't realize but there's actually an AppVeyor build setup: https://ci.appveyor.com/project/makomweb/emkay-s3

That should be linked in the README so it can be found from Github, plus it would be good to put a build status badge in.

Hey guys,

Any chance you can update the nuget package if it now works with the new amazon sdk?

I was looking to add a couple things, but the code seems like it could use some cleanup.

One of these things is separate method for "WithHeaders". Why bother? Why not just call PublishFiles? If you pass header metadata (which I guess is any metadata?) it sets headers. If you don't want to set headers, don't pass metadata.

As is, there's effectively two implementations of Publish methods and 3 layers of duplicated code leading into S3Client.PutFile() or S3Client.PutFileWithHeaders() which are 98% identical.

Perhaps could deprecate the WithHeaders methods, leaving them in (inheriting and identical), but I get the sense this isn't heavily used enough that this would be a huge deal..?

When an error occurs during publishing, only the message of the exception is logged:
https://github.com/makomweb/Emkay.S3/blob/master/Emkay.S3/PublishFiles.cs#L50

I would like to be able to see the entire details of the exception, including the stack trace to help diagnose and troubleshoot the issue.

I am currently experiencing an error and this is the only error message in the build log:

Publishing folder has failed because of A WebException with status RequestCanceled was thrown.

I would probably make a pull request to the forked repository here:
https://github.com/Dealermade/DM.Emkay.S3

Thank you.

Hey,

It may be me but I think your repo is now broken:

1. Your dependency is the incorrect version of AWSSDK (I did a PR to fix that up)
2. I got "Publishing folder has failed because of No RegionEndpoint or ServiceURL configured", this is fixed by specifying the region in S3Client when creating the AmazonS3Client.
3. After fixing those you get "Method not found: 'Void Amazon.S3.Model.PutObjectRequest.set_Timeout(System.Nullable`1<System.TimeSpan>)'", http://stackoverflow.com/questions/8608274/having-problems-accessing-bucket-that-is-not-using-us-region-with-the-net-sdk suggests that this method is no longer available.

I am going to roll back to the previous version. I stopped after getting error 3. I hope this helps you.

Adam

There's a ton of extra junk in here that seems unnecessary to me. First of all, Interfaces that all only have one implementation is a bit useless. Is there a concrete case where other instances are used?

Moq is used in unit tests, but Moq can be used to mock concrete classes.. so having all the extra interfaces just to support Moq (which doesn't need them) seems overkill to me. I realize this can be a contentious issue as some people don't like to mock concrete classes, but it adds lots of extra code and layers to deal with with absolutely zero benefit.

The other one that I find extraneous along the same lines is the S3ClientFactory. There's only one S3Client instance.. So Factory is unnecessary here. Driving it home, the implementation is one line!!

public class S3ClientFactory : IS3ClientFactory
{
    public IS3Client Create(string key, string secret)
    {
        return new S3Client(key, secret);
    }
}

}

Before I do a PR, is the project maintainer open to these changes?

Thank you for Emkay.S3.

I would like to request the ability to specify the buffer size when uploading files to S3.

For example,

    <PublishFiles
      Key="$(Key)"
      Secret="$(Secret)"
      Bucket="$(Bucket)"
      SourceFiles="@(SourceFiles)"
      DestinationFolder="$(DestinationFolder)"
      BufferSizeKiloBytes="65536"
      TimeoutMilliseconds="$(TimeoutMilliseconds)" />

It seems the default buffer size is 8k but if it can be set to a higher value from MSBuild, uploading large files will be faster.

Thank you!