Giter VIP home page Giter VIP logo

guides's Introduction

guides's People

Contributors

abellotti avatar agrare avatar ailisp avatar bdunne avatar blomquisg avatar carbonin avatar cben avatar chessbyte avatar chrisarcand avatar d-m-u avatar durandom avatar fryguy avatar himdel avatar ilpianista avatar imtayadeway avatar jrafanie avatar karelhala avatar kbrock avatar ladas avatar martinpovolny avatar mfeifer avatar mzazrivec avatar naltun avatar nicklamuro avatar pilhuhn avatar romanblanco avatar skateman avatar slemrmartin avatar subpop avatar tzumainn avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

guides's Issues

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

github-actions
.github/workflows/ci.yaml
  • actions/checkout v4
  • ruby/setup-ruby v1
  • actions-ecosystem/action-regex-match v2
  • peter-evans/repository-dispatch v3

  • Check this box to trigger a request for Renovate to run again on this repository

Can we use community styles for Percent Array literals?

I have been frustrated with our current override of the defaults for a while now, and have not been completely silent about it in the past:

ManageIQ/manageiq-providers-amazon#434 (comment)
ManageIQ/manageiq-providers-amazon#434 (comment)

And I don't think I am alone...

I would like to petition we change this back to the community styles.

(I also willingly take on the work to update our code bases to use this style, as this would very much ease a long standing "erk-some" I have had with it)

Reference links

[VOTE] Disable Naming/VariableNumber Cop

https://docs.rubocop.org/rubocop/1.19/cops_naming.html#namingvariablenumber

This cop is annoying particularly in specs. What do you think about disabling entirely? I'm not sure what we really gain by keeping it except that it's noise.

Example PR that shows the bot complaining about it: ManageIQ/manageiq-providers-ibm_cloud#374, where it's complaining about these symbols: https://github.com/ManageIQ/manageiq-providers-ibm_cloud/pull/374/files#diff-d54a15a03812a47a8fca6738fa419467a30720611dd2f8bf976d99a120f8876eR35-R44

๐Ÿ‘ Disable completely
๐Ÿ‘Ž Keep as is
๐Ÿ˜• Disable but only parts of it (such as only for symbols or only for method names)

Developer setup fails on `bin/setup`

I'm using CentOS 7 and running through the developer setup instructions. When I get to bin/setup, it appears that some of the validation tests fail.

...
...
== Removing old logs and tempfiles ==

== Preparing tests ==
** Confirming rails environment does not connect to the database
** Preparing database
rake aborted!
PG::ConnectionBad: FATAL:  Ident authentication failed for user "user"
/home/erjohnso/manageiq/lib/tasks/evm_dba.rake:141:in `block (3 levels) in <top (required)>'
/home/erjohnso/manageiq/lib/tasks/test.rake:31:in `block (2 levels) in <top (required)>'
Tasks: TOP => db:drop => db:check_protected_environments
(See full trace by running task with --trace)

So, I added --trace to the setup script and poked around my environment a bit. The last test, db:check_protected_environments, comes from a rails / active_record test suite.

I'm running PostgreSQL 9.2.14.

postgres=# \du
                             List of roles
 Role name |                   Attributes                   | Member of 
-----------+------------------------------------------------+-----------
 erjohnso  | Superuser                                      | {}
 postgres  | Superuser, Create role, Create DB, Replication | {}
 root      | Superuser                                      | {}

postgres=# \l
                                     List of databases
       Name       |  Owner   | Encoding |   Collate   |    Ctype    |   Access privileges   
------------------+----------+----------+-------------+-------------+-----------------------
 postgres         | postgres | UTF8     | en_US.UTF-8 | en_US.UTF-8 | 
 template0        | postgres | UTF8     | en_US.UTF-8 | en_US.UTF-8 | =c/postgres          +
                  |          |          |             |             | postgres=CTc/postgres
 template1        | postgres | UTF8     | en_US.UTF-8 | en_US.UTF-8 | =c/postgres          +
                  |          |          |             |             | postgres=CTc/postgres
 vmdb_development | root     | UTF8     | en_US.UTF-8 | en_US.UTF-8 | 
 vmdb_test        | root     | UTF8     | en_US.UTF-8 | en_US.UTF-8 | 
(5 rows)

Repeated bin/setup executions fail the same way. I can also repro the error if I run rake test:vmdb:setup.

Any thoughts or other info I can provide?

Thank you!

Ubuntu developer setup does not work

Using rbenv, and following the directions, bin/setup fails to properly configure the database.

Missing from the instructions are versions, almost none are listed.

I've burned almost two days on this already.

Here is the result of bin/setup:

== Migrating database ==
bower not-cached https://github.com/himdel/jquery.observe_field.git#~0.1.0
bower resolve https://github.com/himdel/jquery.observe_field.git#~0.1.0
bower not-cached https://github.com/himdel/spice-html5-bower.git#~1.6.3
bower resolve https://github.com/himdel/spice-html5-bower.git#~1.6.3
rails aborted!
LoadError: No such file to load -- environment_management
/home/jonz/RubymineProjects/manageiq/lib/extensions/as_include_concern.rb:54:in rescue in include_concern' /home/jonz/RubymineProjects/manageiq/lib/extensions/as_include_concern.rb:49:in include_concern'
/home/jonz/RubymineProjects/manageiq/app/models/miq_server.rb:8:in <class:MiqServer>' /home/jonz/RubymineProjects/manageiq/app/models/miq_server.rb:3:in <top (required)>'
/home/jonz/RubymineProjects/manageiq/lib/vmdb/settings/database_source.rb:70:in my_server' /home/jonz/RubymineProjects/manageiq/lib/vmdb/settings/database_source.rb:39:in resource'
/home/jonz/RubymineProjects/manageiq/lib/vmdb/settings/database_source.rb:60:in settings_holder' /home/jonz/RubymineProjects/manageiq/lib/vmdb/settings/database_source.rb:43:in load'
/home/jonz/RubymineProjects/manageiq/lib/patches/config_patch.rb:3:in reload!' /home/jonz/RubymineProjects/manageiq/lib/vmdb/settings.rb:59:in for_resource'
/home/jonz/RubymineProjects/manageiq/lib/vmdb/settings.rb:18:in init' /home/jonz/RubymineProjects/manageiq/config/application.rb:140:in block in class:Application'
/home/jonz/RubymineProjects/manageiq/config/environment.rb:5:in <top (required)>' bin/rails:4:in require'
bin/rails:4:in <main>' LoadError: No such file to load -- miq_apache /home/jonz/RubymineProjects/manageiq/app/models/miq_server/environment_management.rb:1:in <top (required)>'
/home/jonz/RubymineProjects/manageiq/lib/extensions/as_include_concern.rb:51:in include_concern' /home/jonz/RubymineProjects/manageiq/app/models/miq_server.rb:8:in class:MiqServer'
/home/jonz/RubymineProjects/manageiq/app/models/miq_server.rb:3:in <top (required)>' /home/jonz/RubymineProjects/manageiq/lib/vmdb/settings/database_source.rb:70:in my_server'
/home/jonz/RubymineProjects/manageiq/lib/vmdb/settings/database_source.rb:39:in resource' /home/jonz/RubymineProjects/manageiq/lib/vmdb/settings/database_source.rb:60:in settings_holder'
/home/jonz/RubymineProjects/manageiq/lib/vmdb/settings/database_source.rb:43:in load' /home/jonz/RubymineProjects/manageiq/lib/patches/config_patch.rb:3:in reload!'
/home/jonz/RubymineProjects/manageiq/lib/vmdb/settings.rb:59:in for_resource' /home/jonz/RubymineProjects/manageiq/lib/vmdb/settings.rb:18:in init'
/home/jonz/RubymineProjects/manageiq/config/application.rb:140:in block in <class:Application>' /home/jonz/RubymineProjects/manageiq/config/environment.rb:5:in <top (required)>'
bin/rails:4:in require' bin/rails:4:in

'
Tasks: TOP => db:migrate => environment
(See full trace by running task with --trace)

Add a provider support matrix

The CFME docs have a section for what versions of providers are supported for each release of CFME. This would be helpful to have for ManageIQ as well.

guides/developer_setup doesn't work as-in (Fedora 23)

I couldn't start the installation with:
gem install bundler -v "~>1.7.4"

but it worked with:
gem install bundler -v "~>1.8.4"
(not sure what exact minimal version is necessary)

Then the "bundle install" command would fail on nokogiri-1.6.7 build, to pass that I had to do:
sudo dnf install rpm-build

Rubocop disable AccessModifierDeclarations?

See https://rubydoc.info/gems/rubocop/0.69.0/RuboCop/Cop/Style/AccessModifierDeclarations

tl;dr

# group (default)
class Foo
  def method0
  end

  private

  def method1
  end

  def method2
  end
end

# inline
class Foo
  def method0
  end

  private def method1
  end

  private def method2
  end
end

I would like to disable this cop. I like inline modifiers, but this new cop is enforcing the group style. I don't think we have a preference collectively, so I'd like to disable it and allow for inline in addition to group.

Please vote with what you think.

๐Ÿ‘ - allow developers to do both group and inline (disable the cop)
๐Ÿ‘Ž - only support group, do not allow inline (leave it as is)
๐Ÿš€ - only support inline, do not allow group (opposite than currently)

Converting a production upstream appliance into a development one

From discussion on SUI gitter room.

Since our upstream appliances are production mode, it would be nice to have directions for people to convert them to dev mode for rebuild purposes. For example, a user wants to change the skinning, but can't because we build the SUI with --production so the build bits are not there.

In "Extending the UI with buttons, dialogs and executing Ansible Playbooks" developer guide there is a broken link for forms

In the following guide Extending the UI with buttons, dialogs and executing Ansible Playbooks (https://www.manageiq.org/docs/guides/ui/provider_plugin).

The form example for React is broken - gives a 404:

image

The link is pointing to https://github.com/ManageIQ/react-ui-components/tree/master/src/amazon-security-form-group

Maybe should go here: https://github.com/ManageIQ/react-ui-components/tree/master/src/forms

Initial TODO items.

  • Rails style guide see https://github.com/bbatsov/rails-style-guide
  • Bugzilla how-to
    • how to copy commit details / clone a ticket
  • Git how-to
    • reword a commit
    • amend a commit
    • squashing
    • reordering
    • deleting a commit
    • uncommit a file from an existing commit
  • Move CFME-specific stuff into CFME proper
    • logs
    • error collection
  • Create CONTRIBUTING.md files on other open source projects that reference this guide. Mirror the one in CFME.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.