The markmacro from manateelazycat

markmacro's Introduction

Hi, I'm ManateeLazyCat

About Me

I often use English name Andy Stewart, my Chinese name is 王勇.

Here are some ideas to get you started:

Self-study computer and programming technology
Mobile game developer (2005 ~ 2007)
Create a clothing factory (2007 ~ 2009)
Pre-CTO of deepin operating system (2010 ~ 2018)
Own several IT companies now (2019 ~ now)
Like self-driving tour, live with kind wife and cute daughter
A lot of time on EAF and lsp-bridge

Skills: Python、C、C++、Emacs Lisp、Haskell、Golang、Vala、JavaScript、Ruby、Lua and more

Welcome to my Chinese blog: manateelazycat.github.io

Coding Life

Recent Activity

markmacro's People

Contributors

Stargazers

Watchers

markmacro's Issues

使用宏重构后的版本，选中的内容不正确

今天pull了最新的代码，发现执行 markmacro-mark-words 以及 markmacro-mark-lines 后选中的内容不正确，看了一下 markmacro-mark-objects 这个宏，由于中间执行了一次 deactivate-mark，导致第二次执行的时候获取的区域是错误的，应该还是需要一个 let 去暂存一下 mark-bound 执行结果

;; 以markmacro-mark-lines为例，mark-bound内容为：
(if (region-active-p)
    (cons (region-beginning) (region-end))   ; 第一次会用选中区域
  (cons (point-min) (point-max))             ; 第二次会用这个，会直接选中整个buffer

(cl-defmacro markmacro-mark-objects (mark-bound func)
  `(when ,mark-bound
     (when (region-active-p)
       (deactivate-mark))                    ; 这里关闭了 region

     (dolist (bound (funcall ,func ,mark-bound))
       (let* ((overlay (make-overlay (car bound) (cdr bound))))
         (overlay-put overlay 'face 'markmacro-mark-face)
         (add-to-list 'markmacro-overlays overlay t)))

     (markmacro-select-last-overlay)))