manu37 / tinymce4 Goto Github PK

I've just noticed that the plugin administration of TinyMCE 4 (and also TinyMCE 3, BTW) can't be accessed anymore under recent CMSimple_XH 1.7. That's been caused by cmsimple-xh/cmsimple-xh#22. initvar() in combination with checking for the value to be truthy isn't sufficient, because $tinymce==='' (before this change in CMSimple_XH, the initvar() has been a no-op, by the way).

I suggest to use XH_wantsPluginAdministration() for the check.

Forwarding from cmb69/realblog_xh#25.

The link and image lists are only available in $edit mode, but not generally in admin mode, so they are missing for editors that are not content editors. TinyMCE 3 always includes the lists; not sure about CKEditor.

I installed latest version at xh172 and the FA-Icons were there - with this versions the icons are not there - just the gray places

1. Nach der Installation auf xH 1.6.10 erhalte ich den Fehler 'Failed to load content css: http://cdn.tinymce.com/4/%BASE_URL%/templates/mini2/stylesheet.css'

In required-classes.php steht :

/define('TINYMCE4_VARIANT', ''); //TinyMCE4 fully installed
define('TINYMCE4_VARIANT', 'CDN'); //TinyMCE4 externally loaded
define('TINYMCE4_CDN_ORIG', '//cdn.tinymce.com/4/tinymce.min.js'); //TinyMCE4 externally loaded

Wo muss ich patchen ?

2. Die schwarzen Icons sind nicht jedermanns Sache. Kann man nicht einen Konfigurationspunkt machen, an dem man zwischen dem alten bunten und dem neuen grauschwarzen Menü umschalten kann ?

Depending on the file system encoding, the OS and PHP version and the PHP configuration, there are issues with non UTF-8 compatible characters in file names in userfiles/downloads/. For instance, often a file named töst.pdf may cause get_internal_links() to return false, because XH_encodeJson() fails, and that causes include_tinymce4() to generate invalid JS.

See cmsimple-xh/cmsimple-xh#347, which I've fixed right away.

TinyMCE 4 distinguishes between %HEADERS% and %PAGEHEADERS% in the block_formats based on $cf[menu][levels]. That doesn't make sense for the new page splitting which doesn't have %PAGEHEADERS% anymore. Instead all headings (<h1> - <h6>) should be presented in ascending order.

Siehe: https://www.tinymce.com/docs/advanced/keyboard-shortcuts/
Ich finde es unglücklich gewählt von den Entwicklern von TinyMCE, in Bezug der Shortcuts für die Überschriften H1, H2 usw.. Die ist für H1 Alt+Shift+1 und Alt+Shift ist auch ein Shortcut zum Umschalten der PC-Tastatur von deutsch auf amerikanisch. Mir ist es schon des öfteren passiert, dass ich meinte eine Taste nicht richtig getroffen zu haben und stellte danach fest, dass ich nebenbei doch auf amerikanisch umgeschaltet habe :(

Wie ich hier lese, wurde das geändert, weil es Probleme unter OS X gab. Jetzt haben die Windows-Nutzer das Problem.
Da bleibt nur, am besten diese Shortcuts nicht zu verwenden. Ändern oder deaktivieren macht auch keinen Sinn, ist nicht Update-sicher. Eine Anfrage diesbezüglich wurde bereits von einem User gestellt, aber keine Antwort bisher.

The algorithm to calculate the file size in KB appears to be wrong, since >> 8 is basically division by 256, but division by 1024 (i.e. >> 10) is desired. See also https://www.cmsimpleforum.com/viewtopic.php?f=10&t=13964&p=67246#p67246.

See https://cmsimpleforum.com/viewtopic.php?f=16&t=12388.

Not sure, if that should be done, but I'm forwarding so that it won't be forgotten. :)

The tinyMCE library is delivered with several languages, the backend with de/en only. Should we reduce the variety of languages to de/en? Additional language packs can be downloaded manually (a hint/link in the help file would help though).

If TinyMCE is loaded from CDN, the text (for instance, the toolbar button's labels) are always in English. It seems that is being caused by the missing language option; the documentation on language_url states:

When using the language option to set the user interface language you may choose to place any language pack(s) in a directory other than the default.

The assignments by reference of $pcf and $ptx are unnecessary, and may be harmful with regard to performance, see https://schlueters.de/blog/archives/181-More-on-references.html.

They also raise a notice in case the arrays are replaced by objects.

Currently, version 4.5.3 is bundled, but there are some bugs which are fixed in newer versions (see, for instance, https://cmsimpleforum.com/viewtopic.php?f=10&t=12706), so updating to latest TinyMCE would be helpful.

As soon as there's a HTML comment in the source-code to be edited (which is always the case in advanced split mode, where the split marker is sent to the editor), TinyMCE throws:

Uncaught TypeError: Cannot read property 'fontFamily' of undefined

That doesn't seem to happen with TinyMCE 4.5.0, but with 4.5.3 and 4.5.5, However, the official TinyMCE demo doesn't appear to have this issue.

See also https://cmsimpleforum.com/viewtopic.php?f=16&t=6453&start=60#p58735 ff.

forwarding from cmb69/realblog_xh#38 (comment)
Constants should be initialized in classes/required_classes.php instead of index.php

I'd like to suggest to have an unminified version of xhplugincall/plugin.min.js in this repo, to make it easier to view diffs (for instance, on PRs).