map588 / trains Goto Github PK

License: The Unlicense

Java 98.82% ANTLR 1.10% CSS 0.09%

trains's Introduction

J.A.M.E.S

The J.A.M.E.S. system is a train system designed for the University of Pittsburgh ECE1140 course. It is a system that controls the dispatching of trains, the movement of trains, and the control of the track. It is split into five main modules: the Centralized Traffic Controller (CTC), the Wayside Controller, the Track Model, the Train Model, and the Train Controller. The CTC is the main dispatcher of the system, the Wayside Controller controls the track, the Track Model represents the track, the Train Model represents the train, and the Train Controller is the software that controls the train.

Installation

The installation guide is available here: Installation Guide

User Guide

The user guide is available here: User Guide

trains's People

Contributors

Watchers

trains's Issues

Doors are not opening at the station

Station side is being displayed correctly, but train doors are not opening at a station

Train Controller Authority is Decrementing the Wrong value

When running the train, the controller gui displays an authority that is decrementing in a way that doesn't align with the rest of the train (train stops with authority leftover).

Defect 1: No Hello World

There is a lack of a hello world script.

Function to drive train when path clear broken

trains/Lab 1/mav_Defect.java

Lines 13 to 22 in ba52b9c

 // This function determines whether the train should continue given 

 // whether the track ahead is clear 

 public static boolean Defect_2(boolean isTrackAheadClear) { 

 if(isTrackAheadClear) { 

 return false; 

 } 

 else { 

 return true; 

 } 

 }

This function is supposed to return true only when the track is clear, however it currently does the opposite.

Wayside red line error with dispatch

We found the issue with red line yard exiting with the wrong switch position, however a decision needs to be made about either switching the yards alt and main switch position names in the CSV or in the PLC code. There may be edge cases with gridlock on sections F,G, and H.

Defect 2: Logic Error Demo

https://github.com/map588/trains/blob/b08610a4d46b5c853e441f1f4bbcf978e22f918b/Lab%201/Defect_2.java#L16C8-L24C81

Just a demonstration that shows a logic error that requires other group members to resolve:

Scenario:
Train Attendant asks if user wants a bottle or not.

User can reply with a Y/N

Yes: Gets Bottle Water
No: Don't get Water

However, I made an error inside the code so the actual outcome is now:

Yes: Don't get water
No: Gets bottle water

Doors not opening when train stops at station

When a train stops at a station, the doors do not open. Or to be more precise the train controller and train model interface do not show either doors as open when the train is stopped at a station.

Train Model E-Brake in GUI doesn't match actual e-brake value

In some scenarios after the E-brake on a train is enabled and then disabled, the Train Model GUI will continue to show the E-Brake as enabled, despite it not being on (train is not slowing down), and Train Controller GUI not showing E-Brake as enabled

CTC GUI fails to Load

Upon running the system and selecting CTC from the main menu, the CTC GUI fails to load

Load function returns opposite case

trains/Lab 1/mav_Defect.java

Lines 24 to 32 in ba52b9c

 // Returns whether the given load is within the maximum load of the train 

 public static boolean Defect_3(float load) { 

 if(maxLoad <= load) { 

 return true; 

 } 

 else { 

 return false; 

 } 

 }

This function is intended to return true when the load of the train is less than or equal to the maximum load of the train, however it currently does not do that.

Trains Not Stopping at Stations in Green Line

Title

Train Controller Signal Failure Detection not Working

Same as title, when activating the signal pickup failure in train model, the train controller is not detecting the corrupted value.

CTC Add Stop Function

Add Stop Function of CTC UI does not schedule train at proper time

Horn function sounds 4 times instead of 3

trains/Lab 1/mav_Defect.java

Lines 6 to 11 in ba52b9c

 // This function sounds the horn three times 

 public static void Defect_1() { 

 for(int i = 0; i <= 3; i++) { 

 System.out.println("Honk!"); 

 } 

 }

This function is supposed to sound the horn 3 times (as stated in the comment), however it actually sounds the horn 4 times.

Wayside Stop on Green Line

When running a singular train on green line, it receives a wayside stop at block 98 while it has remaining authority. An upcoming switch was currently turned off

	// This function determines whether the train should continue given
	// whether the track ahead is clear
	public static boolean Defect_2(boolean isTrackAheadClear) {
	if(isTrackAheadClear) {
	return false;
	}
	else {
	return true;
	}
	}

	// Returns whether the given load is within the maximum load of the train
	public static boolean Defect_3(float load) {
	if(maxLoad <= load) {
	return true;
	}
	else {
	return false;
	}
	}

	// This function sounds the horn three times
	public static void Defect_1() {
	for(int i = 0; i <= 3; i++) {
	System.out.println("Honk!");
	}
	}

map588 / trains Goto Github PK

trains's Introduction

J.A.M.E.S

Installation

User Guide

trains's People

Contributors

Watchers

trains's Issues

Recommend Projects

Recommend Topics

Recommend Org