mapbox / mapbox-gl-shaders Goto Github PK

See this special case in the gl-native #pragma implementation, and the FIXME above.

Should the type (vec4 or float) be a part of the #pragma declaration itself, so that the heuristic isn't necessary?

cc @lucaswoj @brunoabinader

https://www.npmjs.com/package/mapbox-gl-shaders started to return 404 recently.

UPD: Actually it looks like the package never was on npm. Why not to publish it?

The fill_pattern and fill_pattern_outline shaders don't use pragmas for the opacity property, so they don't support data-driven opacity. I'm not sure what will happen if you try to use fill-pattern plus a property function for opacity in gl-js.

Eventually there should be no appearances of #if[n]def MAPBOX_GL_JS in the shader sources.

• missing in native: "#mapbox pragma" commands support
• missing in native: overdraw inspector
• circle
  • missing in native: convert mat4 exMatrix to a vec2 extrudeScale
  • missing in native: Enabled data-driven styling for circle-radius
  • missing in native: Reduce shader boilerplate, refactor "Bucket"
• collisionbox
• debug
• fill
  • missing in native: separate u_opacity from u_color
  • missing in js: Use glClear to draw solid background fills if they are the bottommost layer
• icon
  • missing in native: convert mat4 exMatrix to a vec2 extrudeScale
• line
  • missing in native: separate u_opacity from u_color
  • missing in native: combine line-width and line-gap-width in shader
• linepattern
  • missing in native: combine line-width and line-gap-width in shader
  • minor organic difference
• linesdfpattern
  • missing in native: separate u_opacity from u_color
  • missing in native: combine line-width and line-gap-width in shader
• outline
  • missing in native: separate u_opacity from u_color
• outlinepattern
  • missing in native: separate pattern size from draw-time variables
• pattern
  • missing in native: separate pattern size from draw-time variables
• raster - native doesn't do crossfading (mapbox/mapbox-gl-native#115):
  • crossfade raster tiles
  • let raster tiles fade in over background
  • clean up raster shader
• sdf
  • missing in native: separate u_opacity from u_color
  • missing in native: convert mat4 exMatrix to a vec2 extrudeScale
  • missing in js: don't clip glyphs with the frustum (mapbox/mapbox-gl-native#2081)

Note that the above links are to commits imported into gl-shaders from gl-js and gl-native: they include the shader changes, but not corresponding .js or .cpp changes. When porting, you'll want to loop up the original commit to see the related changes to .js or .cpp files.

It can be calculated via a_texture_pos = a_pos * 32767 / 8192.

8192 is the EXTENT constant, and 32767 is some other magic constant (not assigned a symbolic name in the source).

Each name should start with the layer type the shader is used for. Words should be separated with underscores.

• icon ⇢ symbol_icon
• sdf ⇢ symbol_sdf
• linepattern ⇢ line_pattern
• linesdfpattern ⇢ line_sdf_pattern
• outline ⇢ fill_outline
• outlinepattern ⇢ fill_outline_pattern
• pattern ⇢ fill_pattern

We need some documentation about how #pragma mapbox works, so that new developers encountering it can gain an understanding without needing to reverse engineer the gl-js and gl-native source.

@lucaswoj @brunoabinader, can you please coordinate on this?

line_sdf.vertex.glsl is missing

#pragma mapbox: define lowp float opacity

and

    #pragma mapbox: initialize lowp float opacity

This likely means that combinations of line-opacity and line-dasharray are not working.

cc @mollymerp

This preamble is in every shader. We can simplify our code by moving it to util.glsl, which is included in every other shader.

#ifdef GL_ES
precision mediump float;
#else
#define lowp
#define mediump
#define highp
#endif

ref 93e3a7b#commitcomment-17604999