Support mapbox-gl 2.0 about underreact HOT 5 OPEN

Why not just add an new option as excludeNodeModules than a hack towards mapbox-gl? As mapbox-gl-js V2.0.1 support external worker, how underrect handle this if we want transpile mapbox-gl-js V2?

If we add special processing towards mapbox-gl, does it mean we should add support for mapbox-gl-style-spec、p-finally and more. I think underreact is a generic webpack based build tool that should not give mapbox-gl a special hack.

from underreact.

It looks like we could fix this by updating the exclude regex in getConfigForNodeModules:

Do we know if doing this works for both gl-js v1 and v2?

from underreact.

Do we know if doing this works for both gl-js v1 and v2?

I'm not sure but this should be pretty easy to test.

from underreact.

@samanpwbb I think you approach of adding gl-js v2 to exclude: /@babel(?:\/|\\{1,2})runtime/, should work. My only suggestion would be to make sure that it is only added if the consumer actually has gl-js v2, so that we dont end up breaking anything for folks using underreact v1. I guess we can do this check by checking the version of gl-js and only then adding the exclusion.

from underreact.

Why not just add an new option as excludeNodeModules than a hack towards mapbox-gl? As mapbox-gl-js V2.0.1 support external worker, how underrect handle this if we want transpile mapbox-gl-js V2?

I think I agree - am going to add a second PR that does this, and defaults to including gl js in the exclude list

from underreact.