Images not loading using default publicDirectory about underreact HOT 7 CLOSED

Also, looks like there is some bug in the way development server is hosting static assets. Needs more investigation.

from underreact.

Sounds to me like there's a bug in Underreact. In @benjamintd's example, during local development the image should be available at localhost:8080/my-site/images/image.jpg. @kepta can you please look into this?

from underreact.

Thanks for opening this issue @otherwiseman , looks like there is a bug in the docs. The default value for publicDirectory is ${project-root}/public/ and not ${project-root}/src/public/.

from underreact.

Thanks for your assistance and for summarizing here @kepta -- images are working in production now and local development is less of a priority so no worries. Appreciate the timely help!

from underreact.

@otherwiseman if you keep your images in the ${project-root}/public/ folder, you should be able to get them working by using a relative link, for eg: <img src="gs01_search.png" > should work both in development and production modes.

However, I suggest keeping your images in ${project-root}/public/images and then reference them like <img src="images/gs01_search.png" > .

from underreact.

Hm, I'd generally recommend (strongly) using root-relative or absolute URLs instead of relative URLs. @kepta What do we need to change about Underreact to enable root-relative URLs to work for public assets?

from underreact.

@davidtheclark I'm running into the same issue with this setup:

• assets are placed in <project-root>/public/images/image.jpg
• in my config I have siteBasePath: '/my-site'
• during local development, I access my index.html file at localhost:8080/my-site/index.html and my file at localhost:8080/images/image.jpg
• in production, the index is at www.example.com/my-site/index.html and the image at www.example.com/my-site/images/image.jpg.

Since I'm loading these images dynamically I can't import them all as documented here.

How do you think we should reference those assets?

from underreact.