Giter VIP home page Giter VIP logo

subways's People

Contributors

alexey-zakharenkov avatar claudiush avatar derdakon avatar duiesel avatar maksimandrianov avatar rostixman avatar vicpopov avatar zverik avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

subways's Issues

Correctly close circular lines

And also lines with repeating stations. To do that, know stop from platforms and expect these to come in packs, not spread out across the route. Example: PL1-ST1-PL2-ST2-PL1-ST3 is unacceptable (as it is now). Ending with PL1 would be also unacceptable. But PL1-ST1-PL2-ST2-ST1-PL1 would be okay: it marks a circular route. The key is in stops: we don't expect two stops for the same station to be an error. Exception is two consecutive identical stops.

Depends on #15.

Multiple Subway lines in Hong Kong, China not being detected

Add yaml and geojson to the planet validator

Right now you have to set up your own validation to get yaml and geojson files. It would be much simpler to fix metro networks if they are created for each network in the world. The main issue would be generating a file name for each network and coming up with a good argument name.

Unique ids for networks

agency_id is now set to zero. It should be calculated somehow: for example, using a hash of a city name.

Subway Lines in Kaohsiung, Taiwan are not being detected

Orange and Red subway routes were built months ago, but are not being picked up by subway validator. See the following node, which has route relations where the two routes intersect.
https://www.openstreetmap.org/node/4580663526

Also, the Circular light rail line is present as a tram route. It looks more like a tram route than light rail as per wikipedia:
https://en.wikipedia.org/wiki/Circular_light_rail

See following node with the route relation for the circular line, as a tram route
https://www.openstreetmap.org/node/4576225719

Circle line in London is truncated

Instead of Hammersmith→Paddington→Edgware Road→Paddington→Edgware Road it stops on the second Paddington. The reverse direction is even worse: it contains only Edgware Road→Paddington and stops one station before the second Edgware Road.

Subway Validator should factor in number of stops on routes more than number of stations

In multiple cases, e.g. Mexico, Los Angeles, Cleveland, multiple Asian cities, station counts don't match station counts for several reasons:

  • If multiple subways or multiple light rail lines stop at the same station location, they may all be associated with a single station node (or associated stop node) or they may be associated with different station nodes with the same station name.

  • If a light rail line and a subway line meet, each requires a separate station node

Counting the number of total stops on all of the applicable routes would be more effective

Promote stop/platform order warnings to errors

Duplicate stop "Улица Скобелевская" in route - check stop/platform order (relation 301485, "Бутовская линия")

and

Inconsistent platform-stop "Измайловская" in route (relation 302149, "3")

Interchange station in Kuala Lumpur

The Rapid KL have a lot of interchange station which is formerly seperated and the platform are not in a same level.

This is the list, I will update later and I hope somebody to update this table too thank youhttp://osmz.ru/subways/malaysia.html.

KL Sentral (Transport Hub)
Bandar Tasik Selatan
Kajang
Sungai Buloh
Subang Jaya
Titiwangsa
Masjid Jamek
Plaza Rakyat plus Merdeka
Hang Tuah
Maluri
Bukit Bintang

And also can anybody put the KL Monorail route into that Rapid Transit table? In Malaysia, monorail is a type of public transport that almost like subway but only one track.

Running validation on a single city

I want to try, how validation works for a single city, e.g. London. I have tried running
./process_subways.py -c London
but it doesn't work and returns HTTP Error 429: Too Many Requests

However that script uses OverpassAPI, so I guess that I need to download .osm myself. Obviously nobody wants to download entire planet.osm (or planet.pbf) if just a single city is needed. Readme mentions osmconvert tool, but I didn't find anything helpful on https://wiki.openstreetmap.org/wiki/Osmconvert to download data for a city without downloading the planet. It would be great if readme explained that step in more details, maybe providing links that explain data importing in-depth.

Construct a railway line

For now, tracks are only checked for holes. We need to keep the longest stretch of tracks (in km, not in way count). Before and after the stretch, missing parts should be interpolated from stations or stop positions.

Tehran metro line 8 not included

Tehran metro line 8 (route=subway) doesn't seem to be picked up properly: https://www.openstreetmap.org/relation/6151834
All stations along the way keep getting flagged as unused.

Does the whole route with all its way segments and nodes need to be completely within the bounding box?
I can't find any other reason - particularly tagging - which would prevent it.

Kuala Lumpur

Actually Kuala Lumpur has only one MRT (subway) and 3 LRT (light rail) Lines (and another one monorail). But the project website-http://osmz.ru/subways/index.html display 4 subway and 0 light rail line. Hope somebody can fix it.

Maps.me output

There is a placeholder in mapsme_subways, it needs to be implemented.

Caching for mapsme export

Every good city should be cached. When loading from a cache (in case a network turned bad), all osm ids should be checked and entities with obsolete ids should be removed. Only if all stations remain and have at least one entrance and exit, the cached network should be used.

Check for backward direction

Each route_master should have at least 2 routes (except circular), plus each route has to have a barward copy (warning).

Machine-readable validation output

Parsing a log is stupid. It should be a JSON with all the source data, so the to_html script doesn't need parsing the source spreadsheet.

Check for platform/stop duplicates in stop_areas

Store entrances (that station share) separately, and check that platforms and stop positions are in only one stop_area. After that maybe support multiple stop_areas with a single station, and stop_area_groups on these.

Keep stop coords and platform objects for route stations

A station is too general: you don't know where to go to board a specific train. Thus, a route station should be a namedtuple with a station object, a platform element and a stop position as a coordinate. The latter should be filled either from a stop_position node, or a platform center, or a station node, better projected onto a railway line.

Unused station

What is meant by the "unused station" warning? For example in Germany every city gets a lot of these warnings. All the stations I checked were in a stop area relation and used by some route.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.