Giter VIP home page Giter VIP logo

Comments (7)

albanm avatar albanm commented on June 13, 2024

The Dockerfile is missing apt-get install -y nodejs;.

Also the npm ci instruction is ran inside a series of commands separated by ";" instead of "&", which probably explains why it failed but did not break the image build.

from tileserver-gl.

acalcutt avatar acalcutt commented on June 13, 2024

I didn't realize i broke this when i was troubleshooting why the npm ci was failing on arm.

If you want to submit a PR to fix this it will help me approve it easier.

from tileserver-gl.

albanm avatar albanm commented on June 13, 2024

Sure, I will prepare a PR.

from tileserver-gl.

albanm avatar albanm commented on June 13, 2024

Is it on purpose that Dockerfile_light references docker-entrypoint.sh and not docker-entrypoint_light.sh ?

from tileserver-gl.

acalcutt avatar acalcutt commented on June 13, 2024

Nevermind, I just fixed is manually, so a pr should not be needed unless you think more changes should be made.

And yes, the name is on purpose. when the publish.js script copies files it renames this file
https://github.com/maptiler/tileserver-gl/blob/master/publish.js#L51

from tileserver-gl.

albanm avatar albanm commented on June 13, 2024

Ok, thanks !

from tileserver-gl.

acalcutt avatar acalcutt commented on June 13, 2024

v4.6.5 light version should be fixed

from tileserver-gl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.