Marc Bouchenoire

Designing and building delightful products, interfaces, and interactions.

Activity

I ~~occasionally~~ listen to things and watch films.

The latest song I listened to.

The latest film I watched.

dimmmensions's People

Contributors

Stargazers

Watchers

dimmmensions's Issues

🚨 blocker: the library can't be used at the moment 🚨

Steps to reproduce

npm init -y
npm install dimmmensions
node -p 'require("dimmmensions").getDimensions(1170, 2532)'

Actual result

TypeError: Cannot read properties of undefined (reading 'screen')
    at /Users/yaroslavs/Projects/wix-private/oops/node_modules/dimmmensions/dist/index.js:1:10485
    at Array.filter (<anonymous>)
    at exports.getDimensions (/Users/yaroslavs/Projects/wix-private/oops/node_modules/dimmmensions/dist/index.js:1:10445)
    at [eval]:1:25
    at Script.runInThisContext (node:vm:129:12)
    at Object.runInThisContext (node:vm:313:38)
    at node:internal/process/execution:79:19
    at [eval]-wrapper:6:22
    at evalScript (node:internal/process/execution:78:60)
    at node:internal/main/eval_string:28:3

Expected result

Can be achieved via workaround:

node -p 'require("dimmmensions").dimensions.splice(14, 1), require("dimmmensions").getDimensions(1170, 2532)'

where the element at index 14 is almost empty { name: 'iPhone 8' } object.

[
  {
    device: 'iPhone',
    landscape: {
      screen: [Object],
      sizeClass: [Object],
      layoutMargins: [Object],
      readableContent: [Object],
      safeArea: [Object]
    },
    name: 'iPhone 12',
    portrait: {
      screen: [Object],
      sizeClass: [Object],
      layoutMargins: [Object],
      readableContent: [Object],
      safeArea: [Object]
    },
    radius: 47.33,
    scale: 3
  },
  {
    device: 'iPhone',
    landscape: {
      screen: [Object],
      sizeClass: [Object],
      layoutMargins: [Object],
      readableContent: [Object],
      safeArea: [Object]
    },
    name: 'iPhone 13',
    portrait: {
      screen: [Object],
      sizeClass: [Object],
      layoutMargins: [Object],
      readableContent: [Object],
      safeArea: [Object]
    },
    radius: 47.33,
    scale: 3
  },
  {
    device: 'iPhone',
    landscape: {
      screen: [Object],
      sizeClass: [Object],
      layoutMargins: [Object],
      readableContent: [Object],
      safeArea: [Object]
    },
    name: 'iPhone 12 Pro',
    portrait: {
      screen: [Object],
      sizeClass: [Object],
      layoutMargins: [Object],
      readableContent: [Object],
      safeArea: [Object]
    },
    radius: 47.33,
    scale: 3
  },
  {
    device: 'iPhone',
    landscape: {
      screen: [Object],
      sizeClass: [Object],
      layoutMargins: [Object],
      readableContent: [Object],
      safeArea: [Object]
    },
    name: 'iPhone 14',
    portrait: {
      screen: [Object],
      sizeClass: [Object],
      layoutMargins: [Object],
      readableContent: [Object],
      safeArea: [Object]
    },
    radius: 47.33,
    scale: 3
  },
  {
    device: 'iPhone',
    landscape: {
      screen: [Object],
      sizeClass: [Object],
      layoutMargins: [Object],
      readableContent: [Object],
      safeArea: [Object]
    },
    name: 'iPhone 13 Pro',
    portrait: {
      screen: [Object],
      sizeClass: [Object],
      layoutMargins: [Object],
      readableContent: [Object],
      safeArea: [Object]
    },
    radius: 47.33,
    scale: 3
  }
]