marcelomorgado / fyght Goto Github PK

Give to a user without connected Metamask a chance to see the game before taking some action.

A problem example: Keeping enemies updated.
To find an approach that can be applied to other similar issues.
To see if The Graph usage can improve blockchain fetching.

Perform refactorization where necessary.

Note: Write unit tests where missing.

Change config to trigger just the changed packages.

Refs:
https://medium.com/@reuvenharrison/using-circleci-with-monorepos-c04b03f9f39c
https://medium.com/labs42/monorepo-with-circleci-conditional-workflows-69e65d3f1bd0
https://discuss.circleci.com/t/does-circleci-2-0-work-with-monorepos/10378/11

Blocked by #5

Menu items:

• My Fyghters
• Fyght! (Show enemies)
• Buy/Sell Fyghters (Not implemented yet)

Should we have a training feature to allow a user to buy for more habilities?

Refs: 60dba8d#diff-71a415af1b0e3179012215988c81173a

For now, the incentives for attackers and targets are the same. To see a way to have an incentive for attackers since they are who pay tx fees.
Note: This can be obsolete when layer 2 is implemented.

For now, npm start should work locally.

To refactor the UI code to use components, state management, etc.

Should the project use redux or another framework like https://github.com/atlassian/react-sweet-state?
Investigate why fetchAllEnemies and myFyghter actions are being called in loop. Is this behavior correct?

For now, we are putting almost all components inside of the presentational/ folder but there are better approaches.
Refs:
https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0
https://reactjs.org/docs/faq-structure.html
https://www.newline.co/fullstack-react/p/using-presentational-and-container-components-with-redux/

For now, we are using only one contract (Fyghters). To see if will be better split smart contracts (e.g. Fyghters, Challenges)

To check which option will be better:
CircleCI
netlify

Greenkeeper or Dependabot

See if there is a way to DRY current code having some calculations from smart contracts.
E.g.

• Bet value
• Gain/Loss

Components like EnemiesContainer and MyFyghterContainer are now with their snapshots like that since Context API setup:

<ContextConsumer>
   <Component />
</ContextConsumer>

Allow a user to deposit more Dais to its fyghter and review deposit during creation.

• DRY skins table
• Show technologies used
• Fill package.json descriptions

For now, the bet amount is $5 fixed. Allow users to switch between some options (e.g. $5, $10, $25 and $50).

The cache was disabled because was ignoring package.json file from subprojects causing CI crash when running.

Fyghters have to be an on-chain option for that. For now, it'll be a fixed option. In the future, players will be able to accept challenges from stronger enemies.

Refs:
https://www.cypress.io/

Some references:
https://www.sitepoint.com/solidity-pitfalls-random-number-generation-for-ethereum/
https://medium.com/@tiagobertolo/how-to-safely-generate-random-numbers-in-solidity-contracts-bd8bd217ff7b
https://hackernoon.com/how-to-generate-random-numbers-in-solidity-lh7rj39s9

An item will improve the fyghter's strength and increase its probability to win a fight.
It should be an ERC721 token.
For now, item will be minted (after each victory? after some XP achievement?)

Some options:
https://thegraph.com/
https://trufflesuite.github.io/artifact-updates/index.html

Extract all hardcoded styles parameters from components

Allows clothes and characters' colors changes. The current avatar have to be changed to SVG.

• Should be a separate feature or we'll have a marketplace for both Fyghters and Items?
• A fyghter can be sold carrying items?

Typechain doesn't support ethers v5 yet. Refs: dethcrypto/TypeChain#205

Keep this feature as it is or change it? Make it easier to understand the UI.
Seems that auto skin change isn't working
Some ideas:

• Do not have to wait until NO_ONE level
• Buy new skins
• "Buy" XP with training (Refs: #54 )
• Change skin without restrictions

An example where v5 can be better than v4: ethers-io/ethers.js#630
Before that change, make sure that Typechain is compatible with v5 (Refs: dethcrypto/TypeChain#205)

The repo should have these packages: contracts and app.

Related to #13 since the game should have a faster user experience.

Charge fee from challenges