get_groups only collects the sugroups of top level groups and only max 10 subgroups about python-keycloak HOT 3 CLOSED

duplicate
Have a look here: #509

from python-keycloak.

The get_group_children ought to be fixed with #534.

I think it's questionable whether we should go down the path of querying all the subgroups recursively. There's a reason Keycloak made these endpoints paginated and single-level, especially when you deal with a lot of groups. It is a nice feature to just get everything, but maybe it shouldn't be the default behavior when calling get_groups without any parameters. The same can be said about the get_users I suppose.

I'd be more prone to create new methods like get_all_groups and get_all_users and keep get_groups and get_users paginated by default. The get_all_groups could have an additional argument like full_hierarchy: bool, which would recursively traverse through the subgroups and fetch their subgroups etc. It could I guess be clumped into single method, maybe something like def get_groups(all: bool = False, traverse: bool = False, query=None).

Would a solution like this suffice? What are your thoughts?

from python-keycloak.

@ryshoooo Hello. Sorry for not replying to this earlier I completed missed this message. I fully agree that get_groups default behavior should not be to fetch all groups. The changes you conducted in #556 looks good and exactly what I needed. Thank you!

from python-keycloak.