marcwrobel / ansible-collection-assertions Goto Github PK

The README of the collection is broken on Ansible Galaxy :

• relative urls link to https://galaxy.ansible.com instead of GiHub
• Heading level 3 are nearly invisible
• requirements (Ansible version, distribution...) are not clearly visible.
• there is no indication on how to contribute to the collection, where are the release notes... (see https://galaxy.ansible.com/community/general for example)

In order to improve assertions readability some variable must be renamed:

• path -> with_path (in assert_that_file, assert_that_path)
• name -> with_name (in assert_that_service)
• multiline_for_content_matching -> using_multiline_for_content_matching (in assert_that_file)
• ignorecase_for_content_matching -> using_ignorecase_for_content_matching (in assert_that_file)
• strict_version_parsing -> using_strict_version_parsing

assert_that_distribution role fail message is wrong : there is a missing comma.

Instead of displaying Expecting one of [ Debian, Debian 10, Debian 10 ] to be in [ OS 1, OS 2, OS 3 ], but none are. it displays Expecting one of [ Debian, Debian 10 Debian 10 ] to be in [ OS 1, OS 2, OS 3 ], but none are..

Currently making assertions on files and files content require both the role assert_that_file and assert_that_path :

- name: 'Assert that /tmp/test exists, is a file, have mode 0640 and belongs to root:root'
  include_role:
    name: 'marcwrobel.assertions.assert_that_path'
  vars:
    path: '/tmp/test'
    has_type: 'file'
    has_mode: '0640'
    has_owner: 'root'
    has_group: 'root'

- name: 'Assert that /tmp/test is Ansible managed'
  include_role:
    name: 'marcwrobel.assertions.assert_that_file'
  vars:
    path: '/path/to/file'
    has_content_matching: '^# Ansible managed'

But making assertions on files is one of the most common type of assertion. In order to reduce the code needed for that it should be possible to make exists, has_type, has_mode, has_owner and has_group assertions with assert_that_file role.