Comments (11)
Are you getting this using batch operations
from react-native-quick-sqlite.
I haven't tried it but looking at the source code, its not using the pzTail
param either.
from react-native-quick-sqlite.
Interesting, but you are better off using the executeBatch
API, that one will not only execute all your operations but also wrap them in a transaction.
from react-native-quick-sqlite.
Lol, no. Splitting a code injected SQL migration on runtime with some special comments is error prone (which we're doing at the moment) and PITA especially when they are meant to be run in one go either way.
Using transactions should be left to the API consumer to do.
from react-native-quick-sqlite.
ah, how could I've known? You are always free to create a PR
from react-native-quick-sqlite.
My apologies if the tone of my message was inappropriate.
Usually (or at least based on my experience) database libraries/drivers execute all the provided statements, or documents or errors out in cases when they don't. Its really unexpected behavior to silently execute input only partially.
from react-native-quick-sqlite.
well... I partially implemented this, the problem is that I'm not sure it is really compatible with the current API? How would you pass different params for each row of the string? I would also have to modify the metadata object and the result object to return an array instead of a single object, which would increase the complexity a bit.
In any case, here is a partial implementation, it consumes all the statements but the returned data is not correct at all.
https://github.com/OP-Engineering/op-sqlite/tree/consume-entire-statement
from react-native-quick-sqlite.
The API needs to be split between
- execute only
- execute and return data
If that doesn't fit in the architecture, throw error instead of failing silently.
from react-native-quick-sqlite.
alright, as you wish. It's implemented in op-sqlite.
from react-native-quick-sqlite.
Why not just improve this library?
from react-native-quick-sqlite.
This one now belongs to Margelo. I started hacking around on the new one out of curiosity and decided to publish it as a new one as it helps me get customers. Nothing against them, just trying to get something back for my time and effort.
from react-native-quick-sqlite.
Related Issues (19)
- Can't init database [immutable and has been frozen] HOT 2
- Expo SDK49 upgrade errors HOT 10
- Add support for detox HOT 2
- Wrong examples in README HOT 2
- Does this library support encryption or is there any future plans to include the same?
- Unable to generate migration HOT 2
- changing location property is not showing the DB HOT 3
- Expo 48 Android Build Error HOT 5
- App crashes on reload with No implementation found for clearStateNativeJsi() HOT 7
- API Documentation incorrectly describes how to open a database
- Support sqlite3_update_hook
- clearState doesn't take care of pending threads HOT 3
- Android: SQL execution error: disk I/O error HOT 1
- Support for react-native-windows and react-native-macos
- How can I export my database or get the file path? HOT 2
- History loss upon migration HOT 3
- Add app group support for iOS
- Base quick-sqlite module not found. Maybe try rebuilding the app. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-quick-sqlite.