marius00 / iagd Goto Github PK

The Help label on the second tab doesn't fit the window and is cut from the right side in Russian Translation (might be an issue as well with other translations where Help translates to a longer word).

The help tab does not support translations.
May also be rather outdated in terms of correct information.

IA sometimes does not loot items (components for example), better feedback needs to be added to explain why.

The following xpac skills has been logged as missing from the item display:

2017-12-13 19:13:55,194 [Main] DEBUG StatTranslator.StatManager templateName: 0, database/templates/skill_modifier.tpl
2017-12-13 19:13:55,194 [Main] DEBUG StatTranslator.StatManager Class: 0, Skill_Modifier
2017-12-13 19:13:55,194 [Main] DEBUG StatTranslator.StatManager characterBaseAttackSpeedTag: 0, CharacterAttackSpeedAverage
2017-12-13 19:13:55,194 [Main] DEBUG StatTranslator.StatManager offensiveTotalResistanceReductionAbsoluteDurationMin: 2,
2017-12-13 19:13:55,194 [Main] DEBUG StatTranslator.StatManager offensiveTotalResistanceReductionAbsoluteMin: 18,
2017-12-13 19:13:55,194 [Main] DEBUG StatTranslator.StatManager skillMaxLevel: 1,
2017-12-13 19:13:55,194 [Main] DEBUG IAGrim.Utilities.ItemHtmlWriter Could not translate skill-modifier stats for "Hellscourge"
2017-12-13 19:14:56,861 [15] WARN StatTranslator.StatManager No stats parsed for modifiers
2017-12-13 19:14:56,861 [15] DEBUG StatTranslator.StatManager templateName: 0, database/templates/skill_modifier.tpl
2017-12-13 19:14:56,861 [15] DEBUG StatTranslator.StatManager Class: 0, Skill_Modifier
2017-12-13 19:14:56,861 [15] DEBUG StatTranslator.StatManager characterBaseAttackSpeedTag: 0, CharacterAttackSpeedAverage
2017-12-13 19:14:56,861 [15] DEBUG StatTranslator.StatManager offensiveElementalModifier: 150,
2017-12-13 19:14:56,861 [15] DEBUG StatTranslator.StatManager offensivePhysicalModifier: 150,
2017-12-13 19:14:56,861 [15] DEBUG StatTranslator.StatManager offensiveSlowPhysicalModifier: 150,
2017-12-13 19:14:56,936 [15] DEBUG StatTranslator.StatManager skillMaxLevel: 1,
2017-12-13 19:14:56,936 [15] DEBUG IAGrim.Utilities.ItemHtmlWriter Could not translate skill-modifier stats for "Spellscourge Bulwark"
2017-12-13 19:14:56,947 [15] WARN StatTranslator.StatManager No stats parsed for modifiers
2017-12-13 19:14:56,947 [15] DEBUG StatTranslator.StatManager templateName: 0, database/templates/skill_modifier.tpl
2017-12-13 19:14:56,947 [15] DEBUG StatTranslator.StatManager Class: 0, Skill_Modifier
2017-12-13 19:14:56,947 [15] DEBUG StatTranslator.StatManager characterBaseAttackSpeedTag: 0, CharacterAttackSpeedAverage
2017-12-13 19:14:56,947 [15] DEBUG StatTranslator.StatManager offensiveLifeLeechMin: 5,
2017-12-13 19:14:56,947 [15] DEBUG StatTranslator.StatManager skillMaxLevel: 1,
2017-12-13 19:14:56,153 [15] DEBUG StatTranslator.StatManager templateName: 0, database/templates/skill_modifier.tpl
2017-12-13 19:14:56,153 [15] DEBUG StatTranslator.StatManager Class: 0, Skill_Modifier
2017-12-13 19:14:56,153 [15] DEBUG StatTranslator.StatManager characterBaseAttackSpeedTag: 0, CharacterAttackSpeedAverage
2017-12-13 19:14:56,153 [15] DEBUG StatTranslator.StatManager skillMaxLevel: 1,
2017-12-13 19:14:56,153 [15] DEBUG StatTranslator.StatManager spawnObjectsTimeToLive: 5,
2017-12-13 19:14:56,153 [15] DEBUG IAGrim.Utilities.ItemHtmlWriter Could not translate skill-modifier stats for "Mythical Spark of Ultos"
2017-12-13 19:14:54,182 [15] WARN StatTranslator.StatManager No stats parsed for modifiers
2017-12-13 19:14:54,182 [15] DEBUG StatTranslator.StatManager templateName: 0, database/templates/skill_modifier.tpl
2017-12-13 19:14:54,182 [15] DEBUG StatTranslator.StatManager Class: 0, Skill_Modifier
2017-12-13 19:14:54,182 [15] DEBUG StatTranslator.StatManager characterBaseAttackSpeedTag: 0, CharacterAttackSpeedAverage
2017-12-13 19:14:54,182 [15] DEBUG StatTranslator.StatManager skillMaxLevel: 1,
2017-12-13 19:14:54,182 [15] DEBUG StatTranslator.StatManager spawnObjectsTimeToLive: 15,
2017-12-13 19:14:54,182 [15] DEBUG IAGrim.Utilities.ItemHtmlWriter Could not translate skill-modifier stats for "Mythical Arcanor, Blade of the Luminari"
2017-12-13 19:14:54,200 [15] WARN StatTranslator.StatManager No stats parsed for modifiers
2017-12-13 19:14:54,200 [15] DEBUG StatTranslator.StatManager templateName: 0, database/templates/skill_modifier.tpl
2017-12-13 19:14:54,200 [15] DEBUG StatTranslator.StatManager Class: 0, Skill_Modifier
2017-12-13 19:14:54,365 [15] DEBUG StatTranslator.StatManager characterBaseAttackSpeedTag: 0, CharacterAttackSpeedAverage
2017-12-13 19:14:54,365 [15] DEBUG StatTranslator.StatManager offensivePhysicalModifier: 150,
2017-12-13 19:14:54,365 [15] DEBUG StatTranslator.StatManager offensiveSlowPhysicalModifier: 150,
2017-12-13 19:14:54,365 [15] DEBUG StatTranslator.StatManager skillMaxLevel: 1,
2017-12-13 19:14:54,365 [15] DEBUG IAGrim.Utilities.ItemHtmlWriter Could not translate skill-modifier stats for "Mythical Colossal Grasp"
2017-12-13 19:14:54,375 [15] WARN StatTranslator.StatManager No stats parsed for modifiers
2017-12-13 19:14:54,375 [15] DEBUG StatTranslator.StatManager templateName: 0, database/templates/skill_modifier.tpl
2017-12-13 19:14:54,375 [15] DEBUG StatTranslator.StatManager Class: 0, Skill_Modifier
2017-12-13 19:14:54,375 [15] DEBUG StatTranslator.StatManager characterBaseAttackSpeedTag: 0, CharacterAttackSpeedAverage
2017-12-13 19:14:54,375 [15] DEBUG StatTranslator.StatManager projectilePiercing: 33,
2017-12-13 19:14:54,565 [15] DEBUG IAGrim.Utilities.ItemHtmlWriter Could not translate skill-modifier stats for "Mythical Dreadscorcher"
2017-12-13 19:14:54,565 [15] DEBUG StatTranslator.StatManager skillMaxLevel: 1,

Better notify if listdlls is missing [ia simply does not start]

Rare edge case, not a priority.

A few issues has been found with the new react-ui edition, related to translations:

• Item slot does not appear translated
• Skill names dont appear translated
• Item names (including (component)) loses their translation after parsing the GD database
• +3 : Anatomy of murder <- whats missing here? 'to' ?
• Clicking 'update item stats' seems to revert the left-side filter to english
• Changing from Japonese to English causes a null ptr exception in ParsingService, with _grimdawnLocation being null
• Crafting page has english recipes

i stashed Mythical Soullance and it is gone!. items will take from stash tap 6 but i can't find them in GD Item Assistant.
i have the same problem with the beta version.

GDIA can't filter items by classes Inquisitor and Necromancer. When I tick the checkbox Inquisitor (for example) GDIA lists all items for all clasees instead. The filter for other classes - Soldier, Nightblade etc works properly

IA does not loot the items in tab 6. Secure transfer on/off ,32/64 bit, loading database doesn't change anything. IA Version 1.2.7028.21129 from 30.03.2019 Error message says items are bugged/duplicates.
transfer.zip

IA does not show setbonuses on items.
Add the functionality, optional via settings.

When IA is unable to detect GD for one reason or another, it's fairly unclear how to proceed.
Should add a link to the help page, "Cannot find Grim Dawn?" => FAQ explanation.

Users keeps complaining about oathkeeper missing.

Not experienced it myself, but would be nice to find steps to reproduce it, add it to the FAQ at least.

Having read http://www.corsix.org/content/dll-injection-and-wow64 it looks like the following is required:

• Update the IA dll to the latest version of Detours (DONE, UNTESTED)
• Setup for compiling the dll as 64bit (DONE)
• Have IA detect if the target process is 32bit or 64bit (DONE)
• Make a command line tool compiled as 64 bit for injecting into GD 64bit from IA 32bit (DONE)
• Update every single export name in the IA DLL (new exports for 64bit)
• Figure out the proper calling convention for 64 bit dlls (see https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2010/9b372w95(v=vs.100))
• Update every single hooked method to fit the 64bit calling convention.

GDIA does not loot any of the new monster infrequents dropped in forgotten gods. It notes that the items are possibly bugged or duplicates. Typically when I get this message the item actually gets looted into GDIA and it dupes the item and so i just sell the one it won't loot. However in this case it doesn't loot the items out of the stash tab at all.

It has looted 5 FG rare items and listed those under unkown item. So it is able to loot some FG items, but it won't take any of the rare MIs.

Here is an image of the MI graphics
https://i.imgur.com/U9ftXHE.png

Here is an image of the error from 1 of the new MIs
https://i.imgur.com/Y10l1YH.png

And here is what the log shows after it doesn't take the items shown in the first image
https://i.imgur.com/ABiQmAy.png

I have tried individual items and the full stash

Please let me know if I can provide any more information as i'm not really sure what to add.

As title says. Perhaps as an option under the settings tab. With an option to deactivate the pop up if someone is sure he wants to delete the item, would be great.

Github is too gimp to post the full error log:
http://grimdawn.dreamcrash.org/ia/misc/github-issue-14.txt

IA with instaloot enabled will sometimes end up looting vendors.

There have been some performance issues with react (especially when resizing IA while items are being displayed)

A possible cause could be the tooltips which unwisely uses a GUID as its identifier.
Probably makes it hard for react to re-utilize.

The Set label has no corresponding tag in tags_ia.txt file so it can't be translated

https://media.discordapp.net/attachments/362336837844467713/553564927974178817/c1232.JPG

The user feedback in chromium (pnotify) should always be shown for at least N seconds, to ensure no feedback is ever lost.

The relic/crafting tab detects a 1/3 component as a whole, incorrectly informing the user that he has the required components to craft the item.

Minor issue though.

First, you do very useful and impressive work, thank you!
I play and use IA in russian. There is search issue with capital letters. For example, I want to find "Воля Бисмиэль". When I type "Воля", IA show 3 item. Notice, it's case insensitive ("Воля" and "воля" do same).

Next I start type "Бисмиэль".

I try "Бисмиэль" without "Воля":

As result, I can't find item, which contain capital letters in name.
I think, it can be SQLite search issue described here.
Believe me, its very annoying, and do me crazy, when i can't find my items! )) Please please fix it!

Multiple reports received about the google drive checkbox not working anymore.

A user has posted a possible explanation on the forum
http://www.grimdawn.com/forums/showpost.php?p=646528&postcount=1765

Currently not a prioritized issue, all users are recommended to use the cloud backup solution.

Errors which happens on the javascript level (inside chromium) should be passed unto the C# application and logged.

Perhaps not distributed for external logging at Site #1 / Site #2 but at least be logged locally, to help with debugging on an individual player level.

When filtering by say shaman, should also list any items which has 'xpac modifiers' for a shaman skill

1. Sync up N items via online sync
2. Delete your database
3. Login to online sync
4. IA starts downloading items
5. Close IA before all N items has been downloaded
6. Open IA

Expected result: IA continues downloading the remaining items.
Actual result: IA only downloads new items, if any.

As an addition to the currently available filtering options like Damage Types, Resistances and Classes add filtering for last items looted or the items looted over the current session.

I believe a filter that would show/hide buddy items would be a benefit.

There is no handling for modifiers to pets via xpac-style skill modifiers.

Example:
http://www.grimdawn.com/forums/showpost.php?p=602670&postcount=1645

When an item is not being looted due to being a duplicate, IA should link to http://grimdawn.dreamcrash.org/ia/help.html?q=DuplicateItem

Somehow..

Seems the mod and GD paths under mods\databases are case sensitive.
When detecting the GD path from multiple sources (maybe one via steam, one via a running GD process) then IA may end up with duplicate entries with different capitalization.

The tags_ia.txt file distributed to community translators contains some errors, it appears to be partially Portuguese, rather than fully English.

Wrong file checked in perhaps..

Could not find tag iatag_ui_oathkeeper in localization, defaulting to iatag_ui_oathkeeper=Oathkeeper

See any item with the suffix "Of the Gildam Arcanum".
It's lacking skill disruption protection "25% Skill Disruption Protection"

Should this be displayed? Or only adds extra noise for a lesser skill?

Epic and legendary items introduced with Forgotten Gods appear as one stack of an "Unknown" item. They can be transferred to and from IA with no problems. I've attached my transfer.gst file with Skytear Hat in the 4th tab, which is one of the items that has this problem. I'll update the attached file with future problematic items I find.

The "which tab to loot from" menu should ideally support however many tabs are in the transfer file.

This can be determined prior to rendering the dialog, and thus be dynamic and ready for all future expansions.

(Simply selecting 'loot from lastest' still works)

1. Parse Grim Dawn (no xpac)
2. Parse Grim Dawn (with xpac)

Expected result: Have expansion tags and icons
Actual result: Have tags, but icons are not parsed.

Due to the recent change in how parsing is done, icons may not be parsed if the user already has more than >1k icons.

Most likely an issue affecting mods as well.

Should perhaps be added as a separate parsing option (a button to parse icons), as it's both a memory intensive process and a non-blocking operation in terms of functionality.

I imported a GDIA backup file and now have a mix of 809 unknowns and my previously saved items from the backup. Not sure why it was unable to parse some items from the backup but not others? I will attach my log file and the backup file I used.
Saturday.zip
log.txt

Some users has expressed the need/desire to tag/label their items and later filter items by tag.

Upgrading from the current Chromium v51 to v63:

• Database/mods + backups + log tabs have right-side padding/cutoff -- settings/buddy might have it as well, but its gray.

When I maximize the GDIA window (via the maximize button in the right upper corner) and then restore the size back the level field is overlapped and can't be seen well

https://media.discordapp.net/attachments/531551808808681472/550110053068439562/Capture111.JPG

IA does not detect when the vendor, inventor or illusionist is open.

This can cause item duplication or item loss situations.

1. Open IA
2. Do not activate any filters
3. Scroll down to the bottom in the item list

Expected result: IA loads more items
Actual result: IA does not load more items.

The copy to clipboard functionality does not appear to be have been ported to the react UI release.

Every time IA is updated, it tries to parse item stats and I'm getting this ltitle gem:

************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
at IAGrim.UI.UpdatingPlayerItemsScreen.bw_RunWorkerCompleted(Object sender, RunWorkerCompletedEventArgs e)
at System.ComponentModel.BackgroundWorker.OnRunWorkerCompleted(RunWorkerCompletedEventArgs e)
at System.ComponentModel.BackgroundWorker.AsyncOperationCompleted(Object arg)

For some reason IA is unable to read the GD arz/arc files while GD is running.

GD has a lock on the files, but even after creating a copy of the files, IA fails reading the copy.

Find a way to let IA parse these files while GD is running.
Obs: May be hard to reproduce, does not occur on all PCs.

See something ala https://github.com/derickbailey/appcontroller/blob/617baa1d82a51ad55a118dfc0403e0be64768a87/src/SimpleOrgChart/Program.cs

Finish the migration to IA using DI.
IA already receives most services as constructor parameters, just lacking a DI framework to fully utilize it.

When i move an item from GDIA to the stash i get the error message
"Cannot deposit item, please ensure Stash 3 is empty" but it still works.

I am using GD 1.0.6.1 with the Ashes of Malmouth expansion.

Best Regards,
Olaf

1. Start a new game
2. Open the private stash
3. Put an item in the last (or wherever configured) tab
4. Without closing the stash, Click S and then select devotions.
5. IA is now in a dupe-prevention state
6. Talk to the smithy or the inventor
7. Close the chat
8. IA deletes the unlooted item.

Initially I've discarded this purely as an "outside factor" issue.. and I still think it's that.. but bears looking into.

Essentially, some users reports that IA crashes and then when they try to start it again, it's not there anymore. It has been deleted.

I cannot fathom how IA could possibly be responsible for such behavior, but it bears looking into.

Ref the latest report: "Hello, I wanted to report a persistent error. It's been several months since I last played GD, but yesterday I decided to pick it up again. After playing for a while, I started your item assistant, which immediately caused both the game and the assistant to close to desktop. I tried running them again, but the assistant's .exe was gone. I tried reinstalling but it wouldnt let me unless I restarted my pc first. This happens every time I try to run both at the same time. This also happens if I start the assistant first, then GD. The moment GD opens, both crash and the .exe gets deleted. I also tried doing a backup of the .exe and pasting it once it got deleted, but the entire installation folder gets locked until I restart my pc (says I dont have permission). Assistant works fine after restart and pasting the backup .exe, but crashes again on GD startup."

Some (or at least one) item grants benefits or +levels to the skill "Nature's Blessing".
Since this is a buff the name comes from "buffSkillName", which IA does not yet handle for xpac skills.