marketingpipeline / media-card-web-component Goto Github PK

Suggestion / Feature Request

Possibly switch the Book API to be Google API or add option to use Google API for books. (possibly other API providers for TV show's / movie's too)

Example of API query: https://www.googleapis.com/books/v1/volumes?q=

Reason why: Google provide's a description for books.

Could be solved by possibly using a api-provider attribute. Example: <media-card type="book" api-provider="Google"></media-card>

Suggestion / Feature Request

Add "book" option for showing off your favorite books via Open Library API

To achieve this we can use the song card theme + one end point.

Tho I will be honest @annoyingmouse struggling reading some of our own project & implementing it myself. 😭

API Documentation can be found here

And example API usage can be found here

To filter / limit results use a param like so limit=1

Book example

Note API calls should only fetch 1 result. As it's un-needed bandwidth / data we are consuming. I do believe the TheMovieDB api does provide an option for this.

Documenting this so I do not forget both!

Contact Details

[email protected]

What happened?

Looking at the code, I noticed this:

  if(this.type === 'song'){
      // this.endPoint = `https://itunes.apple.com/search?term=${this.name}&entity=song`
      this.endPoint = `https://search-itunes.vercel.app?term=${this.name}&entity=song` // for testing
    }

Did you mean to leave the testing version live and the 'real' endpoint (I assume) commented?

What type of browser are you seeing the problem on?

Firefox

Code to produce this issue.

FYI, I couldn't submit the issue w/o picking a browser. I'd make that optional as I'm sure there will be bugs not tied to one particular browser.

Contact Details

No response

What happened?

Constructed style sheets do not work for iOS, possibly add a statement to check for support and if not render different version of web component? @annoyingmouse

What type of browser are you seeing the problem on?

Safari

Code to produce this issue.

No response