marko-js-archive / marko-util Goto Github PK

Bug Report

Example:

module.exports = function(markoCli) {
  markoCli.config.mochaOptions = {
    colors: true // Boolean value
  };
};

Current Result

Results in the following generated args:

[ '/app/node_modules/@marko/test/util/server-tests-runner/mocha-tests-server.js', '--colors', true]

Expected Result

[ '/app/node_modules/@marko/test/util/server-tests-runner/mocha-tests-server.js', '--colors']

Example:

module.exports = function(markoCli) {
  markoCli.config.mochaOptions = {
    colors: false // Boolean value
  };
};

Current Result

Results in the following generated args:

[ '/app/node_modules/@marko/test/util/server-tests-runner/mocha-tests-server.js', '--colors', true]

Expected Result

[ '/app/node_modules/@marko/test/util/server-tests-runner/mocha-tests-server.js']

When running in Linux boxes (like CI), puppeteer throws an error like this:

Server running at http://localhost:1024
An error occurred while running command test: Error: Failed to launch chrome!
[0302/234340.554390:FATAL:zygote_host_impl_linux.cc(123)] No usable sandbox! Update your kernel or see https://chromium.googlesource.com/chromium/src/+/master/docs/linux_suid_sandbox_development.md for more information on developing with the SUID sandbox. If you want to live dangerously and need an immediate workaround, you can try using --no-sandbox.

This can be avoided by passing arguments to the launcher like

.launch({args: ['--no-sandbox']})

puppeteer/puppeteer#290 (comment)

which would be applied here:
https://github.com/marko-js/marko-util/blob/67dfc0c908b40cdec496b1c356afd81103d13c26/packages/test/util/browser-tests-runner/index.js#L233

Original issue here:
eBay/ebayui-core#1

Mocha 4 does not exit automatically by default without supplying the --exit flag. mochajs/mocha#2879

Currently I have test.server.js and test.browser.js which are recognized, and then run in the correct environments. I am also working on performance testing which I don't want marko-cli to pick up at all. If I name it something like test.performance.js, it gets matched and defaulted to browser, based on this code: https://github.com/marko-js/marko-util/blob/f1b74ac9c507b99421b2b7a6d80b0fd86c3a2df3/packages/test/util/loadTests.js

Is this expected?

Some tests might depend on specific lasso flags for bundling, so it would be useful to be able to configure the flags to this util (through marko-cli).

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper integration’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.