markt-de / puppet-nextcloud Goto Github PK

Currently nextcloud::config only supports system configs. Would be great if you could also add config settings into apps using php occ config:app:set.

Hey there.
I've been managing a bigger nextcloud instance and stumbled upon a problem while migrating data from the native data folder to a symlink of another folder.

In our exact scenario, we want to use another path (for example /mnt/nextcloud) and make a symlink from /opt/nextcloud-data to /mnt/nextcloud.
The problem in this being, that the puppet module doesn't allow me to define another folder or symlink, since that directory is already a defined object:

It would be great to have a toggle, that allows me to "skip" the automatic creation of the data folder in order to define my own puppet file element with a toggle like manage_datadir => false.

Hey there,
I've been trying out what happens to this module on a partial or total storage loss.
In my testing, the data dir /opt/nextcloud-data is located on a different, network attached storage.

When simulating an outage on said external storage server by turning it off, the fstab mount of course get's wanky.

What's interesting in that is what happens when the puppet client tries to make a run during said outage:
Puppet gets stuck on fact checking and (since the datadir with the current puppet-nextcloud status information is missing) assumes that nextcloud is not installed - and then triggers a complete reinstall.

It would be great to implement a stop command which completely skips the complete install/update and housekeeping process if the state files are missing - something like: skip_on_stateless => true, so that the installation doesn't nuke itself, should storage become available again.

Edit: I know install_enabled can be set to false, but this doesn't completely disables the module module in an error state - also it stops you from using the upgrade functionality, when there is no stateloss.

Nextcloud 21 comes with a new "Files High Performance Back-end", packaged in the form of a new notify_push app.

Roughly, the setup works as follows:

1. Install app in nextcloud. This ships backend binaries for 3 platforms (aarch64, armv7 and x86_64).
2. Setup a daemon service that starts the backend service
3. Configure apache/nginx/whatever to proxy requests to /push/ to the new service (the /push/ prefix must be stripped), including /push/ws/ for websockets
4. Run occ notify_push:setup to verify the connection and enable usage of the new backend

At least the first two steps could be done by this module, behind a new $manage_notify_push flag.

The app comes with a setup-wizard that supports setting this up for systemd+apache/nginx based setups, but I don't think this is a feasible approach for integration into the module. Here is the code that generates the systemd service file. This should probably be done with camptocamp/systemd?

Attached is the rc.d/nextcloud_notify_push I've whipped up for FreeBSD (at least the run user would have to be set by the template)

The $config system supports setting Arrays and Structs (php associative arrays), but for some config keys, an Array of Structs is required.

The most prominent example is perhaps apps_paths:

'apps_paths' => [
        [
                'path'=> '/var/www/nextcloud/apps',
                'url' => '/apps',
                'writable' => true,
        ],
],

I expected to be able to use this from hiera yaml as:

nextcloud::config:
  app_paths:
    - path: /opt/nextcloud/apps
      url: /apps
      writable: false
    - path: /opt/nextcloud-user-apps/
      url: /user-apps/
      writable: true

This fails with:

parameter 'value' expects a value of type Boolean, Integer, or String, got Struct
parameter 'verify_value' expects a value of type Boolean, Integer, or String, got Struct

Currently, this can be worked around by putting the array indices into the key names:

nextcloud::config:
  app_paths 0:
      path: /opt/nextcloud/apps
      url: /apps
      writable: false
  app_paths 1:
      path: /opt/nextcloud-user-apps/
      url: /user-apps/
      writable: true

Perhaps the code from nextcloud::config can be extracted into a recursive function to properly support this?

The passwords here https://github.com/markt-de/puppet-nextcloud/blob/main/manifests/install.pp#L46-L48 aren't escaped properly , so if your password has special shell characters it will try to expand them and the password you think you set probably won't work.

Hello,
it looks like nextcloud::install_enabled is ignored.
I have the following setup in hiera:

---
profile_base::puppetagent::version: 'latest'
nextcloud::install_enabled: false
nextcloud::update_enabled: false
nextcloud::installroot: '/var/www/html/'

However the puppetrun still complains about an error in part of puppet code that should be ignored.
Log from puppet run:

# puppet agent -t
Info: Using environment 'sandbox'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Error: Failed to apply catalog: Could not find dependency File[/var/www/html//nextcloud-26.0.2] for Archive[Extract archive: update to 26.0.2] (file: /etc/puppetlabs/code/environments/sandbox/modules/upstream/nextcloud/manifests/install/distribution.pp, line: 64)