marktennyson / flask-mailing Goto Github PK

Implement the feature to send emails directly by using the send_mail or send_mass_mail methods very similar to Django.

Getting an error about a duplicate class with one of the modules used in this library.

Sep 21 07:03:38 flaskweb[3047]: from flask_mailing import Mail
Sep 21 07:03:38 flaskweb[3047]: File "/usr/local/lib/python3.11/dist-packages/flask_mailing/init.py", line 88, in
Sep 21 07:03:38 flaskweb[3047]: from . import utils
Sep 21 07:03:38 flaskweb[3047]: File "/usr/local/lib/python3.11/dist-packages/flask_mailing/utils/init.py", line 1, in
Sep 21 07:03:38 flaskweb[3047]: from .email_check import DefaultChecker, WhoIsXmlApi
Sep 21 07:03:38 flaskweb[3047]: File "/usr/local/lib/python3.11/dist-packages/flask_mailing/utils/email_check.py", line 5, in
Sep 21 07:03:38 flaskweb[3047]: import aioredis
Sep 21 07:03:38 flaskweb[3047]: File "/usr/local/lib/python3.11/dist-packages/aioredis/init.py", line 1, in
Sep 21 07:03:38 flaskweb[3047]: from aioredis.client import Redis, StrictRedis
Sep 21 07:03:38 flaskweb[3047]: File "/usr/local/lib/python3.11/dist-packages/aioredis/client.py", line 32, in
Sep 21 07:03:38 flaskweb[3047]: from aioredis.connection import (
Sep 21 07:03:38 flaskweb[3047]: File "/usr/local/lib/python3.11/dist-packages/aioredis/connection.py", line 33, in
Sep 21 07:03:38 flaskweb[3047]: from .exceptions import (
Sep 21 07:03:38 flaskweb[3047]: File "/usr/local/lib/python3.11/dist-packages/aioredis/exceptions.py", line 14, in
Sep 21 07:03:38 flaskweb[3047]: class TimeoutError(asyncio.TimeoutError, builtins.TimeoutError, RedisError):
Sep 21 07:03:38 flaskweb[3047]: TypeError: duplicate base class TimeoutError

$SUBJECT

the actual name was very confusing to me...

Fakeredis module issue. Need to fix the broken test cases.

is there any way to NOT use async ?

whitout async I get:

RuntimeWarning: coroutine 'Mail.send_message' was never awaited mailer.send_message(msg)

using async is fine, no errors, the mail goes trough,
but everything else in my app is sync, and I don't want to fall in "what color is your function ?"

Pydantinc isn't required for the flask app.

https://docs.pydantic.dev/2.0/migration/#basesettings-has-moved-to-pydantic-settings

There is an issue in flask-mailman package issue list opened by @pelika. Code sample is from flask-mailing package and should be checked.

waynerv/flask-mailman#37 (comment)

The following settings worked for Flask-Mail:

MAIL_SERVER = 'smtp.mailtrap.io'
MAIL_PORT = 2525
MAIL_USE_SSL = False
MAIL_USE_TLS = True
MAIL_USERNAME = 'xxxxxxxx'
MAIL_PASSWORD = 'xxxxxxxx'
MAIL_DEFAULT_SENDER = '[email protected]'

However in Flask-Mailing. the app has error:

Traceback (most recent call last):
  File "/usr/local/bin/flask", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/site-packages/flask/cli.py", line 990, in main
    cli.main(args=sys.argv[1:])
  File "/usr/local/lib/python3.8/site-packages/flask/cli.py", line 596, in main
    return super().main(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1062, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1668, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 763, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/decorators.py", line 84, in new_func
    return ctx.invoke(f, obj, *args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/click/core.py", line 763, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/flask/cli.py", line 845, in run_command
    app = DispatchingApp(info.load_app, use_eager_loading=eager_loading)
  File "/usr/local/lib/python3.8/site-packages/flask/cli.py", line 321, in __init__
    self._load_unlocked()
  File "/usr/local/lib/python3.8/site-packages/flask/cli.py", line 346, in _load_unlocked
    self._app = rv = self.loader()
  File "/usr/local/lib/python3.8/site-packages/flask/cli.py", line 402, in load_app
    app = locate_app(self, import_name, name)
  File "/usr/local/lib/python3.8/site-packages/flask/cli.py", line 273, in locate_app
    return find_best_app(script_info, module)
  File "/usr/local/lib/python3.8/site-packages/flask/cli.py", line 68, in find_best_app
    app = call_factory(script_info, app_factory)
  File "/usr/local/lib/python3.8/site-packages/flask/cli.py", line 119, in call_factory
    return app_factory(*args, **kwargs)
  File "/usr/src/app/flask_skm/__init__.py", line 122, in create_app
    mail.init_app(app)
  File "/usr/local/lib/python3.8/site-packages/flask_mailing/mail.py", line 63, in init_app
    self.config = ConnectionConfig(
  File "pydantic/env_settings.py", line 36, in pydantic.env_settings.BaseSettings.__init__
  File "pydantic/main.py", line 406, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 1 validation error for ConnectionConfig
MAIL_FROM
  value is not a valid email address (type=value_error.email)

MAIL_FROM is set here:

and perhaps would be better as

     MAIL_FROM = app.config.get("MAIL_FROM", app.config.get("MAIL_DEFAULT_SENDER")),

(or add MAIL_FROM in the "basic_demo"/documentation.

Hey,
how can I change the current sender? I can set a DEFAULT_SENDER and a SENDER during plugin initialization (can anyone explain the difference? But that’s another topic…). But how do I change the sender for a specific message? The message schema doesn't have such a key – but maybe I do miss something?

Best
Pascua

Hello,

It is very common that you don't need to authenticate to your mail server when using a smart/relay host setup.
However, when I try to leave them unset I get the following error.

MAIL_USERNAME
none is not an allowed value (type=type_error.none.not_allowed)
MAIL_PASSWORD
none is not an allowed value (type=type_error.none.not_allowed)

httpx==0.18.2 is in requirements.txt but not in setup.py - therefore have issue when installing via pip.

Looks like it was present in 8e93e9 , but removed in 65fb04b

What happened

pip install Flask-Mailing==0.0.4

>>> from flask_mailing import Message

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-7d6b88669445> in <module>
----> 1 from flask_mailing import Message

~/miniconda3/envs/flask-testing/lib/python3.8/site-packages/flask_mailing/__init__.py in <module>
      2 from .config import  ConnectionConfig
      3 from .schemas import Message, MultipartSubtypeEnum
----> 4 from . import utils
      5 
      6 

~/miniconda3/envs/flask-testing/lib/python3.8/site-packages/flask_mailing/utils/__init__.py in <module>
----> 1 from .email_check import DefaultChecker, WhoIsXmlApi
      2 
      3 
      4 __all__ = ["DefaultChecker", "WhoIsXmlApi"]

~/miniconda3/envs/flask-testing/lib/python3.8/site-packages/flask_mailing/utils/email_check.py in <module>
      1 import dns.resolver
      2 import dns.exception
----> 3 import httpx
      4 import inspect
      5 import aioredis

ModuleNotFoundError: No module named 'httpx'

Work around

Install httpx manually

pip install httpx>=0.18.2

More examples are required to describe all the apis perfectly.