Giter VIP home page Giter VIP logo

helm-charts's People

Contributors

achaussier avatar alexanderbabel avatar dependabot[bot] avatar jacksgt avatar martialblog avatar mueller-ma avatar p- avatar renovate-bot avatar renovate[bot] avatar toabi avatar w3irdrobot avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

helm-charts's Issues

Version Label won't reflect correct version when using image.tag

Not an issue, just confusing.

When someone changes the Image tag, for example when running '3-apache'

image:
  tag: '3-apache'

The label will still be

labels:
  app.kubernetes.io/version: 5-apache

Maybe we should use coalesce in _helpers instead:

{{- if .Chart.AppVersion }}
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}

should:

app.kubernetes.io/version: {{ coalesce .Values.image.tag .Chart.AppVersion | quote }}

https://helm.sh/docs/chart_template_guide/function_list/#coalesce

If the Ingress is enabled the Base/Public URLs need to be the Ingress' host

For example if you set

ingress:
  enabled: true
  hosts:
    - host: limesurvey.local
      paths:
        - path: /
          pathType: Prefix

then the baseUrl und publicURL need to be limesurvey.local. Maybe we can provide some logic to do that in the template, so that it works out-of-the-box

- name: BASE_URL
  value: {{ .Values.limesurvey.baseUrl }}
- name: PUBLIC_URL
  value: {{ .Values.limesurvey.publicUrl }}

How to handle LimeSurvey 3 LTS

Besides some Variables I don't think we need to change much for the LimeSurvey 3 LTS

These are not required:

  encrypt:
    keypair: ""
    publicKey: ""
    secretKey: ""
    nonce: ""
    secretBoxKey: ""

Anything else? ๐Ÿค”

ejabberd Helm chart missing from index.yaml

Hi,

I noticed that the reference to the ejabberd chart has vanished from the index.yaml - I believe it used to be there.

https://martialblog.github.io/helm-charts/index.yaml

The last CI jobs also mentions the chart, so I'm not sure which puzzle piece is missing:

Looking up latest tag...
Discovering changed charts since 'ejabberd-0.1.0'...
WARNING: .github/Chart.yaml is missing, assuming that '.github' is not a Helm chart. Skipping.
Nothing to do. No chart changes detected.

https://github.com/martialblog/helm-charts/actions/runs/6081404816/job/16496989259

Liveness and readiness probes not configurable

In our case, the default Timeout for liveness and readiness are 1s,

This sometimes set the Ready state to 0/1 as the pod was too slow to answer in a few cases.
Basically forcing the pod to restart.

Adjusting the Probe timeouts within the values chart may be helpful.

livenessProbe:
            failureThreshold: 3
            httpGet:
              path: /
              port: http
            periodSeconds: 10
            successThreshold: 1
            timeoutSeconds: 5
readinessProbe:
            failureThreshold: 3
            httpGet:
              path: /
              port: http
            periodSeconds: 10
            successThreshold: 1
            timeoutSeconds: 5

we just hardcoded the timout manually in the deployment.yaml currently, but adjusting it within the values yaml should help.

Kubernetes probes are generating large amounts of logs

The pods readiness probes are generating large amount of logs.
Within one minute:

10.42.0.17:80 10.42.0.1 - - [09/Jul/2021:20:17:55 +0000] "GET / HTTP/1.1" 200 46788 "-" "kube-probe/1.21"
10.42.0.17:80 10.42.0.1 - - [09/Jul/2021:20:17:55 +0000] "GET / HTTP/1.1" 200 46788 "-" "kube-probe/1.21"
10.42.0.17:80 10.42.0.1 - - [09/Jul/2021:20:18:05 +0000] "GET / HTTP/1.1" 200 46788 "-" "kube-probe/1.21"
10.42.0.17:80 10.42.0.1 - - [09/Jul/2021:20:18:05 +0000] "GET / HTTP/1.1" 200 46788 "-" "kube-probe/1.21"
10.42.0.17:80 10.42.0.1 - - [09/Jul/2021:20:18:15 +0000] "GET / HTTP/1.1" 200 46788 "-" "kube-probe/1.21"
10.42.0.17:80 10.42.0.1 - - [09/Jul/2021:20:18:15 +0000] "GET / HTTP/1.1" 200 46788 "-" "kube-probe/1.21"
10.42.0.17:80 10.42.0.1 - - [09/Jul/2021:20:18:25 +0000] "GET / HTTP/1.1" 200 46788 "-" "kube-probe/1.21"
10.42.0.17:80 10.42.0.1 - - [09/Jul/2021:20:18:25 +0000] "GET / HTTP/1.1" 200 46788 "-" "kube-probe/1.21"
10.42.0.17:80 10.42.0.1 - - [09/Jul/2021:20:18:35 +0000] "GET / HTTP/1.1" 200 46788 "-" "kube-probe/1.21"
10.42.0.17:80 10.42.0.1 - - [09/Jul/2021:20:18:35 +0000] "GET / HTTP/1.1" 200 46788 "-" "kube-probe/1.21"
10.42.0.17:80 10.42.0.1 - - [09/Jul/2021:20:18:45 +0000] "GET / HTTP/1.1" 200 46788 "-" "kube-probe/1.21"
10.42.0.17:80 10.42.0.1 - - [09/Jul/2021:20:18:45 +0000] "GET / HTTP/1.1" 200 46788 "-" "kube-probe/1.21"
10.42.0.17:80 10.42.0.1 - - [09/Jul/2021:20:18:55 +0000] "GET / HTTP/1.1" 200 46793 "-" "kube-probe/1.21"
10.42.0.17:80 10.42.0.1 - - [09/Jul/2021:20:18:55 +0000] "GET / HTTP/1.1" 200 46788 "-" "kube-probe/1.21"

We might want to reduce the interval.
Maybe we can tell Apache to shut up about these probes.

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Detected dependencies

github-actions
.github/workflows/lint-test-charts.yaml
  • actions/checkout v4
  • helm/chart-testing-action v2.6.1
  • addnab/docker-run-action v3
.github/workflows/release-charts.yaml
  • actions/checkout v4
  • azure/setup-helm v3.5
helm-values
ejabberd/values.yaml
limesurvey/values.yaml
helmv3
limesurvey/Chart.yaml
  • mariadb 11.x

  • Check this box to trigger a request for Renovate to run again on this repository

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.