Comments (10)
effort is not an issue, I want this to be perfect. the issue is about consistency... old images only had glow for rares and epics and mostly because they were taken from screenshots.
if we want to add glow we would have to add transparent pixels to cards without glow (commons and legendaries) to preserve the unity of image sizes.
anyway I uploaded the files for now but rather work on the arenas. I also have them clean with pixel perfect edges including the new legendary arena.
most likely work on them tomorrow along with the new double-chest and the new league Icons
from clash-royale-api.
I have extracted the game textures and have the latest card art, they're high quality border-less and without the elixir drop atm, I can provide them as they are or add borders and give you them as PNGs, are you interested?
from clash-royale-api.
Of course! If you can, add the border, update the images in the images
folder and submit a pull request. Thanks!
from clash-royale-api.
Do you care for the rarity glow (golden for rares and pink for epics)? like do you consider it a feature or is it not needed.
and what about the elixer drop?
atm I have all PNGs ready with borders and without the glow nor the elixir drop. imo I think they look cleaner like this but it's up to you.
also wanted to double check with you about the "idName" (image names) for the new cards, I used:
- bandit
- night-witch
- bats
- heal
from clash-royale-api.
It is OK without the glow and the elixir drops, I am not sure how much effort should mean adding the glow and how it would look like. If you want, submit a pull request as you have it now and if you want to add the glow and submit a new pull request in the future, it's up to you.
The names are OK like that, thanks!
from clash-royale-api.
Update: @MaherFa here is the json of updated cards. As soon as I add the new chests and leagues information, it will be in production.
from clash-royale-api.
Thank you so much. I will work on chest images and submit them later. Do you prefer them opened or closed. I will be creating them out of the original mutipart animation sprites. So I can create whatever frame we want. Any preferance?
from clash-royale-api.
You are the expert here, just see which one looks better and go ahead with that one.
Thanks again for all your time!
from clash-royale-api.
API is now up to date. @MaherFa I will create a issue for you to update the chests images, is it OK?
from clash-royale-api.
No need, chests are ready
from clash-royale-api.
Related Issues (20)
- Card: Magic Archer HOT 3
- Royal Ghost bad image HOT 1
- Error 500 Internal Server Error HOT 6
- Markdown standards for README.md
- Wrong Name and URL for Donate App
- Bad card image (Hunter) HOT 1
- Proposal to lower the load and improve stability HOT 1
- [card.idCopy] In game copy-id of cards HOT 16
- not an actual api for clash royale HOT 10
- Rascals?? HOT 2
- Clan Information HOT 4
- Can you add my app to read me please. HOT 3
- Add new cards and reorder existing cards
- [Discussion][Improvement]Add the new emotes
- The skeletons' description is wrong? HOT 1
- Official Clash Royale API HOT 6
- Update API to support 12/12 update HOT 1
- Provide localized card names HOT 2
- Improve images HOT 3
- Consume API via HTTPS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clash-royale-api.