Giter VIP home page Giter VIP logo

Comments (10)

MaherFa avatar MaherFa commented on May 31, 2024 1

effort is not an issue, I want this to be perfect. the issue is about consistency... old images only had glow for rares and epics and mostly because they were taken from screenshots.
if we want to add glow we would have to add transparent pixels to cards without glow (commons and legendaries) to preserve the unity of image sizes.

anyway I uploaded the files for now but rather work on the arenas. I also have them clean with pixel perfect edges including the new legendary arena.

most likely work on them tomorrow along with the new double-chest and the new league Icons

from clash-royale-api.

MaherFa avatar MaherFa commented on May 31, 2024

I have extracted the game textures and have the latest card art, they're high quality border-less and without the elixir drop atm, I can provide them as they are or add borders and give you them as PNGs, are you interested?

here's a sample
cr_72

after adding the border
card

from clash-royale-api.

martincarrera avatar martincarrera commented on May 31, 2024

Of course! If you can, add the border, update the images in the images folder and submit a pull request. Thanks!

from clash-royale-api.

MaherFa avatar MaherFa commented on May 31, 2024

Do you care for the rarity glow (golden for rares and pink for epics)? like do you consider it a feature or is it not needed.
and what about the elixer drop?
atm I have all PNGs ready with borders and without the glow nor the elixir drop. imo I think they look cleaner like this but it's up to you.

also wanted to double check with you about the "idName" (image names) for the new cards, I used:

  • bandit
  • night-witch
  • bats
  • heal

from clash-royale-api.

martincarrera avatar martincarrera commented on May 31, 2024

It is OK without the glow and the elixir drops, I am not sure how much effort should mean adding the glow and how it would look like. If you want, submit a pull request as you have it now and if you want to add the glow and submit a new pull request in the future, it's up to you.

The names are OK like that, thanks!

from clash-royale-api.

martincarrera avatar martincarrera commented on May 31, 2024

Update: @MaherFa here is the json of updated cards. As soon as I add the new chests and leagues information, it will be in production.

from clash-royale-api.

MaherFa avatar MaherFa commented on May 31, 2024

Thank you so much. I will work on chest images and submit them later. Do you prefer them opened or closed. I will be creating them out of the original mutipart animation sprites. So I can create whatever frame we want. Any preferance?

from clash-royale-api.

martincarrera avatar martincarrera commented on May 31, 2024

You are the expert here, just see which one looks better and go ahead with that one.

Thanks again for all your time!

from clash-royale-api.

martincarrera avatar martincarrera commented on May 31, 2024

API is now up to date. @MaherFa I will create a issue for you to update the chests images, is it OK?

from clash-royale-api.

MaherFa avatar MaherFa commented on May 31, 2024

No need, chests are ready

from clash-royale-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.