martinsson / refactoring-kata-lift-pass-pricing Goto Github PK

There are two little differences in the Scala version compared to all other solutions:

1. PUT does not return content-type JSON.
2. cost for nightly without an age is 8 instead of 0 like in TS.

Also maybe log level could be turned to Warn when running the application.

ping @seblm

@codecop I updated the master branch, so it's ready for being adapted to your java port

The used MySQL driver is too old in the TypeScript version. A newer driver has a different API, so some modifications have to be done.

It'd be great to have a CI (travis, circleci, ..) to avoid systematically testing all PRs to the with_tests branch by hand.

Note: Possibly one could imagine to do the same for the master branch, but that'd require the tests to actually pass whereas now they fail in order for people to see where to start. Either way let's start with configuring a CI on the with_tests branch

There is a small inconsistency to the other projects - because also typescript version has it.

1. There is a main entry point (class, whatever) which calls createApp and then gets the connection and the application. It will print a message with a test URL and proper port (look into index.ts in the Typescript) and then starts the app by listening. So please instead of having the run of app in the main method of Prices, please create a separate file.

2. The createApp is also returning the connection, so tests can close it after running. I do not see the tests closing the connection, maybe a method provided to shutdown of process? I think it's OK to get the values app and importing by running the module like it is now, connection is just available globally then?

Originally posted by @codecop in #61 (comment)

I don't know if it's "by-design" to have deprecated code in a refactoring kata, but if you want, I can fix it.

@codecop started working on this: https://github.com/codecop/Refactoring-Kata-Lift-Pass-Pricing/tree/wip