marusyk / binarytree Goto Github PK

It would be great to add some xml documentation to public api

public BinaryTree(IEnumerable<T> collection)

As the library depends only from .Net Standard 2.0 it would be great to use cake build and Travis to run build on Linux

Hi, Guys.I am a Chinese Programmer.this is my first issue in English,perhap the issue will be unreadable,I mean my speech maybe very terrible ,but please read this suggestion.
I Suggested that wee can changed TraversalStrategy class type from class to interface

Now it is

Let's improve that

This project is a simple implementation of binary tree. It would be greate to have some suggestions how it can be improved. Maybe some ideas for new features.

Check if we can do some performance improvements. Benchmarks

Use PackageIcon instead of PackageIconUrl to fix warning NU5048

NuGet.Build.Tasks.Pack.targets(221, 5): [NU5048] The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl

Need to add check input params for public methods/constructors

The wrong constructor of ArgumentOutOfRangeException is used ArgumentOutOfRangeException(string? paramName)

Should be changed to

throw new ArgumentOutOfRangeException(nameof(capacity), "Capacity should be more then zero.");

It should be visible on the Readme page.
See example: Marusyk/grok.net#30

It would be great to have some description of binary tree operations complexity in README.md

Using Xunit instead of Ms Tests to run test on Linux

There exists property IsReadOnly that never used.

https://msdn.microsoft.com/en-us/library/92t2ye13(v=vs.110).aspx

Need to extend https://github.com/Marusyk/BinaryTree/blob/master/src/BinaryTree/EnumerableExtensions.cs to add a pretty print function (like tree)

Need to add unit tests

GitHub is working on replacing the term "master" on its service with a neutral term like "main" to avoid any unnecessary references to slavery

See https://github.com/github/renaming

Extend workflow with: https://github.com/zbeekman/EditorConfig-Action