Giter VIP home page Giter VIP logo

five-dice's Introduction

Hi ๐Ÿ‘‹, I'm Marvin

@Marvin-Brouwer

My Github stats

marvinbrouwer on twitter marvinbrouwer on dev.to

About me:

Currently still working on my readme.

Languages and Tools:

csharp dotnet azure html5 javascript typescript nodejs react

I am primarily a C# dotnet developer but I like to mess around with Typescript in my spare time.

five-dice's People

Contributors

marvin-brouwer avatar

Watchers

 avatar  avatar

five-dice's Issues

Undo

Is your feature request related to a problem? Please describe.
Add a button to undo the last turn.

Describe the solution you'd like
You should only be able to undo one turn.

Describe alternatives you've considered
n/a

Additional context
n/a

Incorrect small straight

Describe the bug
Small straight is an incorrect option

To Reproduce
Steps to reproduce the behavior:

  1. Enter 1 1 2 3 5
  2. Small straight is selectable

Expected behavior
It shouldn't be selectable

Additional context
This was the score:
Screenshot_20231021-212613.png

share-card

Is your feature request related to a problem? Please describe.
When I share the website on WhatsApp (or other social media), I'd like to show a proper description with a big version of the favicon.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
NA

Additional context
This is what it looks like currently:
image

Can't close keyboard by clicking backdrop

Describe the bug
Can't close keyboard by clicking backdrop

To Reproduce
Steps to reproduce the behavior:

  1. Open the new-roll dialog
  2. Open the dice keyboard if not already
  3. Click or tap on the backdrop
  4. Doesn't close

Expected behavior
The keyboard should hide.

Screenshots
NA

Additional context
Additionally, pressing escape should close the keyboard, pressing escape again should close the new-rol dialog.
It cannot close both at once.

Playtest app

This is a todo to make sure playtesting happens

Finalize accessibility statement

Is your feature request related to a problem? Please describe.
The accessibility of this site leaves a lot of room for improvement.

Describe the solution you'd like

  • Finish statement
  • Make all aria-descriptions make sense

Describe alternatives you've considered
NA

Additional context
NA

Add lighthouse pipeline

Is your feature request related to a problem? Please describe.
We'd like to periodically check the sites perf

Describe the solution you'd like
Lighthouse

Describe alternatives you've considered
None yet

Additional context
NA

Large staight is also incorrect

Describe the bug
Currently all combinations of 5 unique dice are accepted

Expected behavior
Only shuffled versions 12345 and 23456 are acceptable.

Add skip to content button

Is your feature request related to a problem? Please describe.
We need a button for keyboard users to skip the nav bar, however short it may be.

Describe the solution you'd like
Like YouTube does it, show the button on tab focus.

Describe alternatives you've considered
NA

Additional context
NA

Write more tests

Is your feature request related to a problem? Please describe.
We kind of stopped writing tests while hacking together this app.

Describe the solution you'd like
We'd first like to test the main app functionality.
However if you decide to help out and want to go all the way, perhaps adding SonarCloud to the pipeline to report on issues and coverage would be awesome.

Describe alternatives you've considered
None, but they're welcome

Additional context
NA

Add linter

Is your feature request related to a problem? Please describe.
The code is pretty chaotic currently.

Describe the solution you'd like
A simple linter would suffice.

Additional context
Not the biggest fan of prettier tbh.

Aces row not selectable when text overlaps

Describe the bug
When the screen is small enough that the text overlaps the aces, the aces aren't selectable.

Expected behavior
The text should not overlap, but even if it does, the aces should be selectable.

Additional context
iPhone 13, safari

Make accessible offline

Is your feature request related to a problem? Please describe.
Since there's no real backend functionality, having the app available offline would be awesome.

Describe the solution you'd like
The simplest way to make an AstroJs app a PWA, doesn't need to be SPA, MPA is fine.
We don't want an install app button, just the offline capacity.

Describe alternatives you've considered
NA

Additional context
NA

Finish readme etc.

Describe the solution you'd like

  • Finish readme
  • Add contribution guide
  • Add license

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.