massgo / league Goto Github PK

After #53, we now have some RESTful routes that are mixed in with templated views. These should be moved to their own namespace, something like /api/v1.0, along with their own subdirectory.

Footer should display contents of VERSION file

Some new metrics:

• Kyu Killer - defeats of kyu players by a dan players
• Dan Demolisher - defeats of dan players by kyu players
• Stoned - handicap stones given

Should be enough to just add to template and episode_stats function

We can edit slack configuration variables after #97, but the current method of changing these variables does not persist over different server sessions.

For this configuration data, when would be the appropriate time to read this data? The current structure of the application factory doesn't have a clean insert point (configuration data is read from the environment before the database is activated).

https://github.com/alecthomas/injector
https://github.com/alecthomas/flask_injector

These look interesting. Would be a good miniproject to rewrite app using these.

Traceback from production:

@hndrewaall said:

I want to have configurable text/banners, at least sufficient to tell people roughly what's happening
so that'll likely involve adding some settings to a config page
and editing templates to load content dynamically

Both player and game pages have checkbox-based delete functions, but both only respect the last item selected. This is due to the form submitting multiple player_id parameters with the POST, but the PlayerCreateForm and GameCreateForm only defining that parameter as a single item. This should theoretically be fixable using a FieldList but I haven't yet gotten it working.

Pros: very easy to do, flexible way to manage adding features.

Cons: I don't know DB theory, but it seems antithetical to normalization and other SQL best practices.

We should add a view for managing Slack config to the Admin settings page. Should include button/route for sending test message. Should retain backwards compatibility for initializing values from env vars

Not urgent, but a security concern that should be addressed in the future.

Introduced here.

^ The above shows player view after episode 3 has started. Should show 0-0 for current episode. Probably just because we are computing latest episode/season locally to player rather than globally.

This looks promising: https://pypi.python.org/pypi/skills

All of the user registration/login forms and routes are currently disabled or have been removed. We need to reenable these, and mark all dashboard pages as requiring authentication to view.

As part of this effort, we should also reenable the public homepage and clean it up.

We will soon need the ability to schedule and queue jobs. Some examples of things we might want it to handle:

• Sending email
• Manage backups
• Perform statistical computations (update ratings etc.)
• Generate graphs

Some ideas for software:

• https://airflow.incubator.apache.org/ : generic DAG task manager. Possibly overkill. Can use Celery for workers.
• http://www.celeryproject.org/ : might be easiest way for executing Python code, not sure how easy it is to use for non-Python tasks (might require Airflow or similar)

The new games view introduced in #53 "seeds" the table using the templater to inject rows as HTML. This results in an unformatted table occasionally being briefly visible as the page loads. We should move this template seeding into the JS block of the template, so we still get the rows without an additional request, but the table loads all at once.

Python datetimes are annoying me, and this looks nice (and has native SQLAlchemy support): http://crsmithdev.com/arrow/

Currently, we simply tag docker images as latest and do no git version tagging whatsoever. We should find a tool and/or build a script to write/update a VERSION file, tag the repo, and tag the docker images built appropriately. Once this is done, we can start managing releases using terraform (as opposed to manually terminating ECS tasks).

We should add views for individual players. These can live under /players/<player_id>. These should include player game histories and statistics.

Currently it is possible for games to have identical play timestamps. Since we rely on these to provide a strict ordering, we should enforce uniqueness at the DB level. Moreover, we should provide validation at the API and UI levels.

Example of duplicate timestamps:

test issue

We really need an about page for league with at least.

• Overview
• Rules

Running this with Andrew's laptop set to west coast time seems to have inconsistent handling of time zones. Affects time played, created, and modified

Hi 👊

This is my first visit to this fine repo, but it seems you have been working hard to keep all dependencies updated so far.

Once you have closed this issue, I'll create seperate pull requests for every update as soon as I find one.

That's it for now!

Happy merging! 🤖

The new games view introduced in #53 does not display errors (such as validation errors) from AJAX requests. This will involve adding a new element, either a modal or a "traditional" bootstrap alert, based on the result of AJAX requests. This should be done before implementing this new interface for Users or Players

A basic (and useful) Slack integration would be to simply post game results as they are added (much like @njritter already does manually)

I've seen this recently on mobile, and I'm pretty sure also at least once with the full version. Authentication seems to just silently fail. Logging shows the POST, but I don't see any error codes. Current prod logging isn't really sufficient to debug this.

There are two levels of CSRF protection in place, and both are manually disabled everywhere. We should decide if we even need both of these, and remove the overrides.

Additionally, where appropriate, we should conditionally disable these based on test config

Like #20, just add a simple view for listing games played for a particular season and/or episode.

We need a cool favicon! And reusing the one we have for Discourse is no good, esp. since we already did that for Wordpress...

Currently anyone can register. For now, I would like to have an admin account created automatically based on an env var, and a page for creating new users.