masterminds / goutils Goto Github PK

GoUtils is a Go implementation of some string manipulation libraries of Apache Commons. This is an open source project aimed at providing Go users with utility functions to manipulate strings in various ways.

License: Apache License 2.0

Go 100.00%

go golang

goutils's People

Contributors

Stargazers

Watchers

goutils's Issues

Implement func WrapCustom(...) with tests

Implement func InitialsCustom(...) with tests

IsEmpty

Use IsEmpty where appropriate (to replace str=="")

randNumeric returns values that are interpreted as octal

randNumeric returns values that are interpreted as octal. This causes problems when randNumeric returns numbers that are invalid octal numbers, like 08 and 09. Errors related to this happen silently when passed to mul and div, resulting in random numbers that are heavily weighted to 0.

EG: when running 1000 iterations of {{ mul (randNumeric 2) 6 }}, the top 5 chosen numbers and their count were:

number	times chosen
30	16
156	17
24	17
468	18
0	36

When attempting things like {{ mul 08 6 }}, {{ div 09 3 }} a parse error arises, but when the octal numbers are generated by randNumeric the octal numbers are accepted and no error is seen.

Implement func Capitalize(...) with tests

RandomStringUtils is not fully implemented (supplied source of randomness)

Looking at Apache commons it appears that we are missing the method with the description "Creates a random string based on a variety of options, using supplied source of randomness."
All of goutils random strings use a default source of randomness instead of being able to supply the seed value.

Implement "useful" StringUtils methods

Implement some "fun/useful" methods from Java Apache Commons StringUtils. Methods such as:

abbreviate (COMPLETED)
indexOfDifference (COMPLETED)
deleteWhitespace (COMPLETED)
IndexOf (CharSeq, int, int) (COMPLETED)
IsEmpty (COMPLETED)
isBlank (COMPLETED)

We don't have to worry about "null safety" methods, as in Golang, strings cannot be assigned nil. Hence, there is no need to duplicate methods already located in the Go strings package for "null safety" considerations.

Implement func CapitalizeCustom(...) with tests

Implement func CapitalizeFully(...) with tests

Implement func Initials(...) with tests

Implement func UncapitalizeCustom(...) with tests

Bug in Wrap

A bug was reported on Sprig that seems to come from the goutils implementation of wrap.

Masterminds/sprig#47

Bug for DeleteWhiteSpace when str is other utf8 string, eg. chinese

func TestDeleteWhiteSpace(t *testing.T) {

	// Test 1
	str := " a b c "
	out := "abc"

	if x := DeleteWhiteSpace(str); x != out {
		t.Errorf("IndexOf(%v) = %v, want %v", str, x, out)
	}

	// Test 2
	str = "    "
	out = ""

	if x := DeleteWhiteSpace(str); x != out {
		t.Errorf("IndexOf(%v) = %v, want %v", str, x, out)
	}

	// Test 3
	str = " 测试 测试 测试 "
	out = "测试测试测试"

	if x := DeleteWhiteSpace(str); x != out {
		t.Errorf("IndexOf(%v) = %v, want %v", str, x, out)
	}
}

$ go test

--- FAIL: TestDeleteWhiteSpace (0.00s)
    stringutils_test.go:157: IndexOf( 测试 测试 测试 ) = æµ�è¯�æµ�è¯�æµ�è¯�, want 测试测试测试
FAIL
exit status 1
FAIL    _/Users/xxxx/Github/goutils       0.371s

Implement func Wrap(...) with tests

Check blank strings properly

Scan code base (mainly wordutils.go) for certain instances of str == "", and replace with goutils.IsBlank(str) IF there is no need to process str that is solely whitespace. (goutils.IsBlank(str) in addition to checking for str == "", ensures that a whitespace string, such as " " isn't used as str for further processing)

Implement func SwapCase(...) with tests

Add travis testing

@mattfarina can you add Travis to this?

maintainer/project contact adress?

Hi. I'm working on packaing this library for debian.

A debian package usually requires an upstream contact adress.

I see that @aokoli is the maintainer of this project but can't find a mail adress. Is there a mail-adress appropriate for this?

Would you be interested in moving this to Masterminds?

Hey Alex!

We've been working on building up a bunch of high-quality Go libraries under the https://github.com/Masterminds project. This is one of the libraries that I still use a lot, and I was wondering if you'd like to join the Masterminds organization with this project. @mattfarina and I would like to help maintain and publicize it.

If not, that's cool. We won't be offended.

Matt

masterminds / goutils Goto Github PK

goutils's People

Contributors

Stargazers

Watchers

Forkers

goutils's Issues

Recommend Projects

Recommend Topics

Recommend Org