mpc is required, but not searched about mate-calc HOT 5 CLOSED

yes it is:

from mate-calc.

Not enough. Without installed mpc headers (mpc devel package), the build fails:

make all-am make[3]: Entering directory '/var/uhubuild/work/compile/src' CC mate-calc.o CC currency.o CC currency-manager.o CC math-buttons.o In file included from currency.h:15, from currency.c:14: mp.h:38:10: fatal error: mpc.h: Nincs ilyen fájl vagy könyvtár 38 | #include <mpc.h> | ^~~~~~~ compilation terminated. make[3]: *** [Makefile:877: currency.o] Error 1 make[3]: *** Waiting for unfinished jobs.... In file included from currency.h:15, from currency-manager.h:14, from currency-manager.c:21: mp.h:38:10: fatal error: mpc.h: Nincs ilyen fájl vagy könyvtár 38 | #include <mpc.h> | ^~~~~~~ compilation terminated. make[3]: *** [Makefile:877: currency-manager.o] Error 1 In file included from math-equation.h:18, from math-buttons.h:16, from math-buttons.c:13: mp.h:38:10: fatal error: mpc.h: Nincs ilyen fájl vagy könyvtár 38 | #include <mpc.h> | ^~~~~~~ compilation terminated. make[3]: *** [Makefile:877: math-buttons.o] Error 1 In file included from math-equation.h:18, from math-window.h:16, from mate-calc.c:18: mp.h:38:10: fatal error: mpc.h: Nincs ilyen fájl vagy könyvtár 38 | #include <mpc.h> | ^~~~~~~ compilation terminated.

So I think, searching mpc is required in PKG_CHECK_MODULES (MATE_CALC, MATE_CALC_CMD).

from mate-calc.

Which distro do you use? Which version of mate-calc? Which is the exact package name and version of mpc you installed?

from mate-calc.

@rezso there is no pc file in the pkgconfig folder for the mpc library. Do you want to add a header check?

diff --git a/configure.ac b/configure.ac
index 47365ff..dac356a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -46,6 +46,7 @@ AC_SUBST(GLIB_MKENUMS)
 
 AC_CHECK_LIB(m, log)
 AC_CHECK_LIB(mpc, log)
+AC_CHECK_HEADER([mpc.h], [], [AC_MSG_ERROR(could not find required headers for MPC)], [])
 
 dnl ###########################################################################
 dnl Internationalization

from mate-calc.

The configure script execution can also be aborted if library checking failed:

diff --git a/configure.ac b/configure.ac
index 47365ff..313f226 100644
--- a/configure.ac
+++ b/configure.ac
@@ -45,7 +45,7 @@ GLIB_MKENUMS=`$PKG_CONFIG --variable=glib_mkenums glib-2.0`
 AC_SUBST(GLIB_MKENUMS)
 
 AC_CHECK_LIB(m, log)
-AC_CHECK_LIB(mpc, log)
+AC_CHECK_LIB(mpc, log, [], [AC_MSG_ERROR(could not find required development libraries for MPC)], [])
 
 dnl ###########################################################################
 dnl Internationalization

Test:

$ ./autogen.sh --prefix=/usr
<cut>
checking for log in -lmpc... no
configure: error: could not find required development libraries for MPC

from mate-calc.