mateoguzmana / react-native-fiesta Goto Github PK

Hey, just encountered this bug when installing via yarn.

Command failed.
Exit code: 127
Command: patch-package
Arguments: 

Version 0.3.1 and below seem to install as expected, but 0.4.0 onward raises this error.

Currently the animation is quite basic, you can see it below:

The aim is to get something a bit closer to this, but considering keeping a decent performance as well.

It would be great to have some animated flowers in Fiesta to celebrate some special occasions.

Ideally the animation can be used with the Popper component, you can use the Hearts or Balloons as examples. The animation can either be created using an SVG as a string or an SVG built with components.

Keeping in mind performance, perhaps the animation can include some flower opening or something else. Leaving it up to the contributor.

Leaving this animation I found in Codepen, some animated flowers with css and canvas.

And below an image as inspiration:

Describe the bug
The library is not compatible with @shopify/react-native-skia > 1.0

To Reproduce
Install the latest version of @shopify/react-native-skia - e.g. 1.2.3

Play a basic animation - e.g.

<Fireworks
      numberOfFireworks={5}
      fireworkRadius={200}
      autoHide={true}
      particleRadius={8}
      theme={['red', 'green', 'yellow']}
    />

This will throw an error: ERROR TypeError: Cannot read property 'linear' of undefined

Expected behavior
The fireworks animation is played.

Additional context
I think the library would need a rewrite to work with skia > 1.0. As pointed out in the skia repo, fiesta would need to migrate to reanimated3.

I see that this probably requires a lot of work. As an alternative: is it possible to set skia as an explicit dependency for fiesta with a version < 1.0? But this would probably bloat up the size of fiesta - right?

Currently there is no documentation for the Popper component.

This component can be very useful for custom animations. Would be good to expose the how to use it under the components section on the Fiesta website. You can follow the documentation structure of the other components

Currently, the Popper component pops the elements in a descending direction by default. We should allow passing a prop to choose the popping direction.

As part of the roadmap for Fiesta, would be great to have some musical notes animation as part of the set.

Ideally the animation can be used with the Popper component, you can use the Hearts or Balloons as examples. The animation can either be created using an SVGs as a string or SVGs built with components.

Perhaps an option to choose which musical notes would be a great addition for the component.

<MusicNotes notes=['...'] />

And below an image as inspiration:

(No need for all of them, leaving it up to the contributor)

Currently, the Fiesta context only allows running an animation passing an animation name, but it is very limited since we can't pass some specific configs such as direction, theming, speed, e.t.c...

Describe the bug
Im trying to install this package, then appear error can not find module for react-native-fiesta, I already tried remove node_modules, yarn.lock, yarn install...

To Reproduce
Steps to reproduce the behavior:

1. Install package with
   yarn add @shopify/react-native-skia 0.1.172
   yarn add react-native-fiesta 0.5.1

2. See error

Screenshots
If applicable, add screenshots to help explain your problem.

As part of the roadmap for Fiesta and because halloween is just around the corner, would be great to have some pumpkins animation as part of the set.

Ideally the animation can be used with the Popper component, you can use the Hearts or Balloons as examples. The animation can either be created using an SVG as a string or an SVG built with components.

Ideal API:

<Pumpkins theme={FiestaThemes.Halloween} />

Below an image for inspiration:

This looks great! Thanks for building it.

Any chance you could add Shopify's infamous confetti effect with customizable colors as per their demo here: https://shopify.engineering/building-arrives-confetti-in-react-native-with-reanimated

Seems like it would be a nice nod to the owners of Skia 😊

To make Fiesta more complete, would be nice to have some christmas animations. Christmas is still a couple of months away but something can be introduced in the meantime.

It can be maybe some ornaments, lights or something else representing Christmas.

Ideally this Christmas animation can be use with the Popper component. You can refer to the Hearts as an example for the implementation.

I leave the image below for inspiration:

Describe the bug
When an animation was executed, I can't interact with my app anymore. It's like there is an invisible Container overall. I need to restart the app.

To Reproduce
I am using the runFiesta hook inside a navigating container/stack together with s button onPress.

Expected behavior
I can still interact with my app/UI after running an animation.

Do you have any idea how such behavior occurs?