Only actions shall be public methods of ApplicationController. (see http://api.rubyonrails.org/classes/ActionController/Base.html)

I used to have #user_locale as a private method.

Now I get the following error message: private methoduser_locale' called for FooController`

RubyGems.org doesn't report a license for your gem. This is because it is not specified in the gemspec of your last release.

via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

Including a license in your gemspec is an easy way for rubygems.org and other tools to check how your gem is licensed. As you can image, scanning your repository for a LICENSE file or parsing the README, and then attempting to identify the license or licenses is much more difficult and more error prone. So, even for projects that already specify a license, including a license in your gemspec is a good practice. See, for example, how rubygems.org uses the gemspec to display the rails gem license.

There is even a License Finder gem to help companies/individuals ensure all gems they use meet their licensing needs. This tool depends on license information being available in the gemspec. This is an important enough issue that even Bundler now generates gems with a default 'MIT' license.

I hope you'll consider specifying a license in your gemspec. If not, please just close the issue with a nice message. In either case, I'll follow up. Thanks for your time!

Appendix:

If you need help choosing a license (sorry, I haven't checked your readme or looked for a license file), GitHub has created a license picker tool. Code without a license specified defaults to 'All rights reserved'-- denying others all rights to use of the code.
Here's a list of the license names I've found and their frequencies

p.s. In case you're wondering how I found you and why I made this issue, it's because I'm collecting stats on gems (I was originally looking for download data) and decided to collect license metadata,too, and make issues for gemspecs not specifying a license as a public service :). See the previous link or my blog post aobut this project for more information.

I added a initializer as the README.md intructs but I get the following error:

.../config/initializers/rails_locale_detection.rb:1:in <top (required)>': uninitialized constant RailsLocaleDetection (NameError) from ../.rvm/gems/ruby-2.2.3/gems/railties-4.1.13/lib/rails/engine.rb:648:inblock in load_config_initializer'

config/initializers/rails_locale_detection.rb

RailsLocaleDetection.config do |config|
config.locale_expiry = 3.months
config.set_default_url_option = :always # valid values are true, false, :always, :never and :explicity
config.detection_order = [:param, :user, :request]
config.automatically_detect = true
config.locale_key = :locale
end

Current version of http_accept_language is 2.0.1.
rails_locale_detection depends on version 1.0.2 from 2011.

Here's the diff of the two versions: iain/http_accept_language@540b750...v2.0.1

The biggest change seems to be that you have to call http_accept_language.preferred_language_from instead of request.preferred_language_from.

Currently it sets ?locale=en in the url in every case.

It should just set it, if the locale got defined by the param before. (locale_from_param)

I'm aware of config.set_default_url_option = false, but this would disable it, even when the locale came from the param

When adding the gem to my Rails 3.2.12 app as suggested (via the Gemfile), I get the following error when starting:

NoMethodError: undefined method `months' for 3:Fixnum
~/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rails_locale_detection-1.3.0/lib/rails/locale_detection.rb:4:in `<module:LocaleDetection>'
~/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rails_locale_detection-1.3.0/lib/rails/locale_detection.rb:2:in `<module:Rails>'
~/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rails_locale_detection-1.3.0/lib/rails/locale_detection.rb:1:in `<top (required)>'
~/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rails_locale_detection-1.3.0/lib/rails_locale_detection.rb:2:in `require'
~/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/rails_locale_detection-1.3.0/lib/rails_locale_detection.rb:2:in `<top (required)>'
~/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/bundler-1.3.0.pre.7/lib/bundler/runtime.rb:68:in `require'
~/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/bundler-1.3.0.pre.7/lib/bundler/runtime.rb:68:in `block (2 levels) in require'
~/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/bundler-1.3.0.pre.7/lib/bundler/runtime.rb:66:in `each'
~/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/bundler-1.3.0.pre.7/lib/bundler/runtime.rb:66:in `block in require'
~/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/bundler-1.3.0.pre.7/lib/bundler/runtime.rb:55:in `each'
~/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/bundler-1.3.0.pre.7/lib/bundler/runtime.rb:55:in `require'
~/.rbenv/versions/1.9.3-p327-perf/lib/ruby/gems/1.9.1/gems/bundler-1.3.0.pre.7/lib/bundler.rb:129:in `require'

If I change the Gemfile line to:

gem 'rails_locale_detection', require: false

And add the following to my initializer before the config:

require 'rails_locale_detection'

Everything works as expected 👍

I've just upgraded a test application to rails 4 and I found that an error was raised in the LocaleDetector, where you delegate the :cookies method to the @controller instance variable.

I believe #cookies has become a private method of the controller in Rails 4.
to overcome this, I've exposed a cookies method in LocaleDetector, that forces the call to the private cookies method in the controller.

You can cherry pick this if you think this is useful.

paolodona@0ec1fda

I could not make the app work in Rails 4 without this workaround.
Paolo